Skip to content

Fixes to guides #16438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 13, 2014
Merged

Fixes to guides #16438

merged 4 commits into from
Aug 13, 2014

Conversation

phi-gamma
Copy link
Contributor

Fixes wording in the runtime, testing and unsafe guides.

@@ -137,7 +137,7 @@ explicitly with, respectively, `value as *const T` and `value as *mut T`).

Going the opposite direction, from `*const` to a reference `&`, is not
safe. A `&T` is always valid, and so, at a minimum, the raw pointer
`*const T` has to be a valid to a valid instance of type `T`. Furthermore,
`*const T` has to be a pointer to a valid instance of type `T`. Furthermore,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this could be reworded to just "has to point to a valid instance".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

···<date: 2014-08-11, Monday>···<from: Huon Wilson>···

@@ -137,7 +137,7 @@ explicitly with, respectively, value as *const T and value as *mut T).

Going the opposite direction, from *const to a reference &, is not
safe. A &T is always valid, and so, at a minimum, the raw pointer
-*const T has to be a valid to a valid instance of type T. Furthermore,
+*const T has to be a pointer to a valid instance of type T. Furthermore,

Maybe this could be reworded to just "has to point to a valid instance".

I concur. What’s the rust-lang policy on these suggestions? Can
you send me a PR so I can include it, or do you prefer me to add
it myself?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just add it to your PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

···<date: 2014-08-12, Tuesday>···<from: Steve Klabnik>···

You can just add it to your PR.

Understood; done.

Following a suggestion by Huon Wilson.
bors added a commit that referenced this pull request Aug 13, 2014
Fixes wording in the *runtime*, *testing* and *unsafe* guides.
@bors bors closed this Aug 13, 2014
@bors bors merged commit 061cdec into rust-lang:master Aug 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants