-
Notifications
You must be signed in to change notification settings - Fork 13.4k
fixes missing rust syntax highlighting in example #16280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The default for syntax highlighting is to be |
I think this might be a GitHub vs. Rustdoc thing. I do like explicitly annotating all of them, even if they don't need it, because of it. |
It's definitely a GitHub vs Rustdoc thing. GitHub doesn't automatically assume |
Actually there is quite some mix of |
I don't see why we should care about the highlighting of the markdown files on GitHub. That's not how they're intended to be viewed. |
Nothing is equivalent to |
@@ -1507,7 +1507,7 @@ a full line of input. Nice and easy. | |||
|
|||
Do you remember this code? | |||
|
|||
``` | |||
```{rust,ignore} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this one now ignore
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the time that I added it, I didn't actually know what the purpose of ignore
is and just noticed that it is sometimes {rust,ignore}
instead of just rust
. Now I know that this means it will be ignored for the tests. Should I change that back to just {rust}
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes please!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated and rebased on latest master
r+=me after the ignore question is resolved. |
No description provided.