Fix misspelled comments for tests. #16182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,7 +8,7 @@ | |||
| // option. This file may not be copied, modified, or distributed | |||
| // except according to those terms. | |||
|
|
|||
| // Verify that UnsafeCell is *always* share regardles `T` is share. | |||
| // Verify that UnsafeCell is *always* shared regardless if `T` is shared. | |||
There was a problem hiding this comment.
I think this one is referring to the trait name, so this should be Share
|
You are awesome and this is awesome. r+=me after that one fix |
|
Thanks! I fixed the regression and updated the branch. |
|
It looks like this may have picked up an extra commit by accident, perhaps a rebase is in order? |
|
One of the build tests failed, but I don't see where my commit contributed. Any suggestions? |
bors
added a commit
that referenced
this pull request
Aug 10, 2014
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 3, 2024
…Veykril internal: Update world symbols request definiton, prefer focus range for macros Prior to this, the symbol search would always jump to the defining macro call, not it jumps to the name in the macro call input if possible. This is a large improvement for assoc items in an attribute impl or trait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.