Remove check run bootstrap #142499
Merged
Remove check run bootstrap #142499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
This PR modifies If appropriate, please update |
This comment has been minimized.
This comment has been minimized.
Shourya742
force-pushed
the
2025-06-14-remove-check-run-bootstrap
branch
from
a750def to
c9eeeb4
Compare
Kobzol
reviewed
Jun 14, 2025
| @@ -1407,26 +1408,23 @@ impl Config { | |||
| git.arg(relative_path); | |||
| git | |||
| }; | |||
| if !self.check_run(&mut update(true)) { | |||
| self.check_run(&mut update(false)); | |||
| if !update(true).allow_failure().run(self) { | |||
| "HEAD", | ||
| ])); | ||
| let has_local_modifications = | ||
| !submodule_git().allow_failure().args(["diff-index", "--quiet", "HEAD"]).run(self); |
| if has_local_modifications { | ||
| self.check_run(submodule_git().args(["stash", "push"])); | ||
| submodule_git().allow_failure().args(["stash", "push"]).run(self); |
| } | ||
|
|
||
| self.check_run(submodule_git().args(["reset", "-q", "--hard"])); | ||
| self.check_run(submodule_git().args(["clean", "-qdfx"])); | ||
| submodule_git().allow_failure().args(["reset", "-q", "--hard"]).run(self); |
|
|
||
| if has_local_modifications { | ||
| self.check_run(submodule_git().args(["stash", "pop"])); |
| @@ -255,7 +244,7 @@ impl Config { | |||
| curl.arg("--retry-all-errors"); | |||
| } | |||
| curl.arg(url); | |||
| if !self.check_run(&mut curl) { | |||
| if !curl.run(self) { | |||
|
@Kobzol , if we look at the implementation of the check_run method, we can see that it skips method execution when a dry run is set and run_always is not specified. By explicitly setting run_always for the commands in this PR, won’t it cause these commands to run even in dry run mode? |
|
Sorry, I only saw the check_run function, and missed that there is also a method with the same name that does actually check dry_run. You're absolutely right! @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jun 16, 2025
Rollup of 10 pull requests Successful merges: - #133952 (Remove wasm legacy abi) - #134661 (Reduce precedence of expressions that have an outer attr) - #141769 (Move metadata object generation for dylibs to the linker code ) - #141937 (Report never type lints in dependencies) - #142347 (Async drop - fix for StorageLive/StorageDead codegen for pinned future) - #142389 (Apply ABI attributes on return types in `rustc_codegen_cranelift`) - #142470 (Add some missing mailmap entries) - #142481 (Add `f16` inline asm support for LoongArch) - #142499 (Remove check run bootstrap) - #142543 (Suggest adding semicolon in user code rather than macro impl details) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jun 16, 2025
Rollup merge of #142499 - Shourya742:2025-06-14-remove-check-run-bootstrap, r=Kobzol Remove check run bootstrap This PR migrates all usage of check_run to new execution context api's. r? `@Kobzol`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates all usage of check_run to new execution context api's.
r? @Kobzol