Add test cases for namespaced crates #142437
Open
+152
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
eholk
commented
Jun 12, 2025
|
|
||
| //@ ignore-test FIXME(packages_as_namespaces): feature not implemented yet | ||
|
|
||
| use my_api; // FIXME can be resolved even though it (maybe?) shouldn't be |
There was a problem hiding this comment.
Suggested change
| use my_api; // FIXME can be resolved even though it (maybe?) shouldn't be | |
| use my_api; |
We should decide the desired behavior before merging this. In this test case, my_api is an open namespace module. I think it makes sense to resolve it, as it's fine to have a module that only contains another module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just to add a few test cases of agreed upon desired behavior for this feature so that future PRs can enable them as they start passing.
I pulled these tests out of #140271.
r? @petrochenkov
cc @b-naber