Skip to content

bootstrap: Remove rustc_snapshot_libdir from PATH in one more place #141917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2025

Conversation

petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Jun 2, 2025

Same as #141657 but in a different part of the build system, with the same goal of addressing #t-infra/bootstrap > Build broken in MSYS2 @ 💬.

It seems to work on windows-{gnu,msvc} and linux-gnu at least.

r? jieyouxu

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 2, 2025
@petrochenkov
Copy link
Contributor Author

@bors rollup=iffy

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jieyouxu
Copy link
Member

jieyouxu commented Jun 2, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 2, 2025

📌 Commit 65730a3 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2025
@bors
Copy link
Collaborator

bors commented Jun 7, 2025

⌛ Testing commit 65730a3 with merge 321dde1...

@bors
Copy link
Collaborator

bors commented Jun 7, 2025

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 321dde1 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 7, 2025
@bors bors merged commit 321dde1 into rust-lang:master Jun 7, 2025
11 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 7, 2025
Copy link
Contributor

github-actions bot commented Jun 7, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c57119b (parent) -> 321dde1 (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 321dde12528a6baf0990ec611d33122b68c33fca --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-rust-for-linux: 2964.8s -> 2528.8s (-14.7%)
  2. aarch64-apple: 4503.0s -> 3972.9s (-11.8%)
  3. x86_64-gnu-llvm-19-1: 3688.1s -> 3285.1s (-10.9%)
  4. x86_64-apple-2: 4244.2s -> 3817.8s (-10.0%)
  5. dist-x86_64-apple: 8576.4s -> 9366.6s (9.2%)
  6. i686-gnu-2: 5920.4s -> 5392.2s (-8.9%)
  7. aarch64-gnu-debug: 3969.5s -> 3635.4s (-8.4%)
  8. i686-gnu-nopt-1: 7872.9s -> 7216.9s (-8.3%)
  9. i686-gnu-1: 7922.0s -> 7289.2s (-8.0%)
  10. x86_64-gnu-distcheck: 8070.8s -> 7437.4s (-7.8%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (321dde1): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -3.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.1% [-5.0%, -1.3%] 2
All ❌✅ (primary) - - 0

Cycles

Results (secondary 1.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.5% [4.5%, 4.5%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.5% [-2.5%, -2.5%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 753.381s -> 752.134s (-0.17%)
Artifact size: 372.54 MiB -> 372.51 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants