Fix citool tests when executed locally #141897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They couldn't be executed locally before due to some additional environment reads.
rustbot
added
A-testsuite
Kobzol
changed the title
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jun 2, 2025
Rollup of 6 pull requests Successful merges: - #141884 (allow macro_use as first segment) - #141885 ([RTE-484] Update SGX maintainers) - #141892 (Fix false positive lint error from no_implicit_prelude attr) - #141894 (rustc-dev-guide subtree update) - #141895 (tshepang has a new email) - #141897 (Fix citool tests when executed locally) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jun 2, 2025
Rollup merge of #141897 - Kobzol:fix-citool-tests, r=marcoieni Fix citool tests when executed locally They couldn't be executed locally before due to some additional environment reads. I also investigated the annoying rebuilds that we see on CI all the time, and they are caused by `ring`'s build script. It should be fixed in the next ring release (briansmith/ring#2525), so we can just wait for that and then update `ring`. r? `@marcoieni`
jieyouxu
pushed a commit
to jieyouxu/rustc-dev-guide
that referenced
this pull request
Jun 3, 2025
Rollup of 6 pull requests Successful merges: - rust-lang/rust#141884 (allow macro_use as first segment) - rust-lang/rust#141885 ([RTE-484] Update SGX maintainers) - rust-lang/rust#141892 (Fix false positive lint error from no_implicit_prelude attr) - rust-lang/rust#141894 (rustc-dev-guide subtree update) - rust-lang/rust#141895 (tshepang has a new email) - rust-lang/rust#141897 (Fix citool tests when executed locally) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They couldn't be executed locally before due to some additional environment reads.
I also investigated the annoying rebuilds that we see on CI all the time, and they are caused by
ring's build script. It should be fixed in the next ring release (briansmith/ring#2525), so we can just wait for that and then updatering.r? @marcoieni