Tweak fast path trait handling

[compiler-errors]

(1.) Make it more sound by considering polarity (lol)

(2.) Make it more general, by considering higher-ranked size/copy/clone

(2.) Make it less observable, by only doing copy/clone fast path if there are no regions involved

r? lcnr

[compiler-errors]

@bors try @rust-timer queue

[bors]

⌛ Trying commit f1da288 with merge 1baaf84...

[bors]

☀️ Try build successful - checks-actions
Build commit: 1baaf84 (1baaf84a9fe1ff3e49fbb767e69f97f98db04a15)

[rust-timer]

Finished benchmarking commit (1baaf84): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	1.1%	[1.0%, 1.2%]	3
Regressions ❌ (secondary)	0.6%	[0.3%, 1.0%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.0%	[-2.4%, -0.3%]	13
All ❌✅ (primary)	1.1%	[1.0%, 1.2%]	3

Max RSS (memory usage)

Results (secondary -0.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.9%	[0.6%, 3.9%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.2%	[-3.8%, -0.4%]	13
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary 0.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.7%	[0.6%, 3.7%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.9%	[-2.3%, -0.4%]	7
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 777.345s -> 779.393s (0.26%)
Artifact size: 368.43 MiB -> 368.50 MiB (0.02%)

[compiler-errors]

regressions don't seem significant, and this is both a fix and an improvement in the new solver.

[rustbot]

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor