-
Notifications
You must be signed in to change notification settings - Fork 13.4k
ci: move tests from x86_64-gnu-llvm-19 job to aarch64 #141576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
d2bde10
to
3e56830
Compare
error: Not sure what's the issue. I'm removing |
3e56830
to
3f281eb
Compare
Oh, right. I think that GCC currently only works for x64. |
This comment has been minimized.
This comment has been minimized.
it's nice that
but I don't know why the arm runner is failing now 😵 |
You'll probably need to add a |
Thanks, I'll do that. At the same time I wonder why this works |
3f281eb
to
9ad8867
Compare
I wonder if they're using different gdb versions, if you want to find out exactly you'll probably need to compare the two gdb versions used, but that test is already kinda broken for aarch64-unknown-linux-gnu / windows-gnu anyway. |
This comment has been minimized.
This comment has been minimized.
this is the failing test: https://github.com/rust-lang/rust/blob/master/tests/run-make/mte-ffi/bar_float.c |
9ad8867
to
1c5733f
Compare
I'm surprised that test doesn't fail on |
can you slap a FIXME pointing to #141600 |
1c5733f
to
1ec0b77
Compare
This comment has been minimized.
This comment has been minimized.
1ec0b77
to
7c12736
Compare
This comment has been minimized.
This comment has been minimized.
7c12736
to
1b7a927
Compare
This PR modifies cc @jieyouxu |
@rustbot ready |
Hmm, together with #119899 this will make the PR CI workflows quite a mess, I hope that it will still be reasonably easy to reproduce the failures locally.. |
Doesn't the method described in this readme work? |
Hopefully yes, what I meant was that some aarch64 specific failures might be hard to reproduce on x64. But these failures would happen on an auto build anyway, so that shouldn't be a UX regression. |
This is a bit time sensitive due to our CI spending. Approving this eagerly, if we run into any issues in practice, we can always revert. @bors r+ |
r? Kobzol |
@bors p=5 (can be included in rollup) |
…=Kobzol ci: move tests from x86_64-gnu-llvm-19 job to aarch64
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 77101fe (parent) -> 40311c4 (this PR) Test differencesShow 1 test diffStage 2
Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 40311c4dcf666e8bddcec4a8059e7d9f12bbd363 --output-dir test-dashboard And then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Finished benchmarking commit (40311c4): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary -4.7%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary -2.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 777.676s -> 778.629s (0.12%) |
This PR splits the tests of the
x86_64-gnu-llvm-19
job in multiple jobs, using two free runners and one 8 core ARM large runner instead of one 16 core x86 runner.One job is still on x86 because it is fast enough.
We are effectively replacing a 16 core large runner with an 8 core, which is more efficient.