-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Dont walk into unsafe binders when emiting error for non-structural type match #141429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bors
merged 1 commit into
rust-lang:master
from
compiler-errors:unsafe-binder-non-structural-match
May 24, 2025
Merged
Dont walk into unsafe binders when emiting error for non-structural type match #141429
bors
merged 1 commit into
rust-lang:master
from
compiler-errors:unsafe-binder-non-structural-match
May 24, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some changes occurred in match checking cc @Nadrieril |
00952f9
to
46606a3
Compare
@bors r+ rollup |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 23, 2025
…structural-match, r=spastorino Dont walk into unsafe binders when emiting error for non-structural type match Fixes rust-lang#141422. The other two binder-having types are also special cased here, unsurprisingly. r? oli-obk
bors
added a commit
that referenced
this pull request
May 24, 2025
Rollup of 8 pull requests Successful merges: - #140790 (Enable xray support for Mac) - #141405 (GetUserProfileDirectoryW is now documented to always store the size) - #141413 (Make #[cfg(version)] respect RUSTC_OVERRIDE_VERSION_STRING) - #141427 (Disable `triagebot`'s `glacier` handler) - #141429 (Dont walk into unsafe binders when emiting error for non-structural type match) - #141438 (Do not try to confirm non-dyn compatible method) - #141444 (Improve CONTRIBUTING.md grammar and clarity) - #141446 (Add 2nd Solaris target maintainer) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 24, 2025
…structural-match, r=spastorino Dont walk into unsafe binders when emiting error for non-structural type match Fixes rust-lang#141422. The other two binder-having types are also special cased here, unsurprisingly. r? oli-obk
This was referenced May 24, 2025
bors
added a commit
that referenced
this pull request
May 24, 2025
Rollup of 7 pull requests Successful merges: - #141405 (GetUserProfileDirectoryW is now documented to always store the size) - #141427 (Disable `triagebot`'s `glacier` handler) - #141429 (Dont walk into unsafe binders when emiting error for non-structural type match) - #141438 (Do not try to confirm non-dyn compatible method) - #141444 (Improve CONTRIBUTING.md grammar and clarity) - #141446 (Add 2nd Solaris target maintainer) - #141456 (Suggest correct `version("..")` predicate syntax in check-cfg) r? `@ghost` `@rustbot` modify labels: rollup
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
May 26, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#141405 (GetUserProfileDirectoryW is now documented to always store the size) - rust-lang#141427 (Disable `triagebot`'s `glacier` handler) - rust-lang#141429 (Dont walk into unsafe binders when emiting error for non-structural type match) - rust-lang#141438 (Do not try to confirm non-dyn compatible method) - rust-lang#141444 (Improve CONTRIBUTING.md grammar and clarity) - rust-lang#141446 (Add 2nd Solaris target maintainer) - rust-lang#141456 (Suggest correct `version("..")` predicate syntax in check-cfg) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #141422.
The other two binder-having types are also special cased here, unsurprisingly.
r? oli-obk