Avoid obligation construction dance with query region constraints #141392

compiler-errors · 2025-05-22T12:28:45Z

And some renaming...

compiler-errors · 2025-05-22T12:28:56Z

@bors try @rust-timer queue

Avoid obligation construction dance with query region constraints And some renaming... r? `@ghost`

bors · 2025-05-22T12:30:08Z

⌛ Trying commit 7b9fdac with merge d224d8a...

bors · 2025-05-22T14:36:48Z

☀️ Try build successful - checks-actions
Build commit: d224d8a (d224d8a37e4be441fd033f5769ffb6d002f36f80)

rust-timer · 2025-05-22T18:30:07Z

Finished benchmarking commit (d224d8a): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.2%, 0.3%]	2
Regressions ❌ (secondary)	0.3%	[0.1%, 0.4%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	1
All ❌✅ (primary)	0.3%	[0.2%, 0.3%]	2

Max RSS (memory usage)

Results (primary -2.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.2%	[-2.2%, -2.2%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.2%	[-2.2%, -2.2%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 777.175s -> 776.048s (-0.15%)
Artifact size: 365.63 MiB -> 365.45 MiB (-0.05%)

compiler-errors · 2025-05-22T19:00:24Z

@bors try @rust-timer queue

bors · 2025-05-22T19:01:36Z

⌛ Trying commit e686e77 with merge f2b1abc...

Avoid obligation construction dance with query region constraints And some renaming... r? `@ghost`

compiler-errors · 2025-05-22T19:06:32Z

@bors try @rust-timer queue

bors · 2025-05-22T19:07:42Z

⌛ Trying commit d531757 with merge be96d2c...

Avoid obligation construction dance with query region constraints And some renaming... r? `@ghost`

bors · 2025-05-22T21:14:14Z

☀️ Try build successful - checks-actions
Build commit: be96d2c (be96d2c49f9f794e4d05033657a99c83cedbe103)

rust-timer · 2025-05-23T01:00:00Z

Finished benchmarking commit (be96d2c): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.1%, 0.6%]	8
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 0.8%, secondary -0.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.8%, 0.8%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.8%	[-0.8%, -0.8%]	1
All ❌✅ (primary)	0.8%	[0.8%, 0.8%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 776.4s -> 777.347s (0.12%)
Artifact size: 365.61 MiB -> 365.48 MiB (-0.04%)

compiler-errors · 2025-05-25T14:14:28Z

Still think this is worthwhile, tho.

rustbot · 2025-05-25T14:14:31Z

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

compiler-errors · 2025-05-25T14:14:32Z

r? lcnr

compiler/rustc_infer/src/infer/outlives/obligations.rs

lcnr · 2025-05-26T08:45:49Z

compiler/rustc_infer/src/infer/outlives/obligations.rs

+        let origin = SubregionOrigin::from_obligation_cause(cause, || {
+            SubregionOrigin::RelateRegionParamBound(cause.span, None)
+        });
+        // `b : a` ==> `a <= b`


Suggested change

// `b : a` ==> `a <= b`

// 'a: 'b ==> 'b <= 'a

lcnr

nit, then r=me

compiler-errors · 2025-05-26T08:48:40Z

@bors r=lcnr rollup

bors · 2025-05-26T08:48:46Z

📌 Commit 9d742ee has been approved by lcnr

It is now in the queue for this repository.

Avoid obligation construction dance with query region constraints And some renaming...

bors · 2025-05-26T08:49:59Z

⌛ Testing commit 9d742ee with merge 1783887...

rust-log-analyzer · 2025-05-26T09:19:59Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Secret source: Actions
Prepare workflow directory
Prepare all required actions
Getting action download info
Failed to resolve action download info. Error: No MediaTypeFormatter is available to read an object of type 'ActionDownloadInfoResponseCollection' from content with media type 'text/plain'.
Retrying in 18.262 seconds
Failed to resolve action download info. Error: No MediaTypeFormatter is available to read an object of type 'ActionDownloadInfoResponseCollection' from content with media type 'text/plain'.
Retrying in 22.129 seconds
##[error]Failed to resolve action download info.
##[error]Failed to resolve action download info.

fee1-dead · 2025-05-26T10:27:19Z

@bors retry

Rollup of 10 pull requests Successful merges: - #140898 (minor improvements on running miri) - #141392 (Avoid obligation construction dance with query region constraints) - #141431 (Emit dummy open drop for unsafe binder) - #141433 (Properly analyze captures from unsafe binders) - #141439 (Deduplicate dyn compatibility violations due to coercion) - #141449 (further deduplicate ast visitor code) - #141513 (interpret: add allocation parameters to `AllocBytes`) - #141516 (speed up charsearcher for ascii chars) - #141526 (add a dedicated section for compiler environment variables in the unstable book) - #141550 (Fix `unused_braces` lint suggestion when encountering attributes) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #141392 - compiler-errors:query-outlives, r=lcnr Avoid obligation construction dance with query region constraints And some renaming...

Rollup of 10 pull requests Successful merges: - rust-lang/rust#140898 (minor improvements on running miri) - rust-lang/rust#141392 (Avoid obligation construction dance with query region constraints) - rust-lang/rust#141431 (Emit dummy open drop for unsafe binder) - rust-lang/rust#141433 (Properly analyze captures from unsafe binders) - rust-lang/rust#141439 (Deduplicate dyn compatibility violations due to coercion) - rust-lang/rust#141449 (further deduplicate ast visitor code) - rust-lang/rust#141513 (interpret: add allocation parameters to `AllocBytes`) - rust-lang/rust#141516 (speed up charsearcher for ascii chars) - rust-lang/rust#141526 (add a dedicated section for compiler environment variables in the unstable book) - rust-lang/rust#141550 (Fix `unused_braces` lint suggestion when encountering attributes) r? `@ghost` `@rustbot` modify labels: rollup

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 22, 2025