Skip to content

tools-aux ci runner: also cross-test doctests in Miri #141210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RalfJung
Copy link
Member

Miri now supports running doctests across different targets. Let's use that to run the std doctests on aarch64-apple-darwin, i686-pc-windows-msvc.

try-job: x86_64-gnu-aux

@rustbot
Copy link
Collaborator

rustbot commented May 18, 2025

r? @albertlarsan68

rustbot has assigned @albertlarsan68.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 18, 2025
$(Q)MIRIFLAGS="-Zmiri-disable-isolation" \
$(BOOTSTRAP) miri --stage 2 library/std \
$(BOOTSTRAP_ARGS) \
--doc -- \
--skip fs:: --skip net:: --skip process:: --skip sys::fd:: --skip sys::pal::
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why I have split up this call into separate --no-doc and --doc invocations... we'll see if anything breaks I guess.^^

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I may have done it to get separate timings. It doesn't seem worth keeping that.

@RalfJung
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented May 18, 2025

⌛ Trying commit 73fcdf6 with merge 1d4757c...

bors added a commit to rust-lang-ci/rust that referenced this pull request May 18, 2025
tools-aux ci runner: also cross-test doctests in Miri

Miri now supports running doctests across different targets. Let's use that to run the std doctests on aarch64-apple-darwin, i686-pc-windows-msvc.

try-job: x86_64-gnu-aux
@RalfJung RalfJung force-pushed the miri-std-doctests branch from 73fcdf6 to 721fb52 Compare May 18, 2025 06:41
@RalfJung
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented May 18, 2025

⌛ Trying commit 721fb52 with merge 7b5d67f...

bors added a commit to rust-lang-ci/rust that referenced this pull request May 18, 2025
tools-aux ci runner: also cross-test doctests in Miri

Miri now supports running doctests across different targets. Let's use that to run the std doctests on aarch64-apple-darwin, i686-pc-windows-msvc.

try-job: x86_64-gnu-aux
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented May 18, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 18, 2025
@RalfJung RalfJung force-pushed the miri-std-doctests branch from 721fb52 to 6eb1afa Compare May 18, 2025 09:37
@RalfJung
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented May 18, 2025

⌛ Trying commit 6eb1afa with merge 1777446...

bors added a commit to rust-lang-ci/rust that referenced this pull request May 18, 2025
tools-aux ci runner: also cross-test doctests in Miri

Miri now supports running doctests across different targets. Let's use that to run the std doctests on aarch64-apple-darwin, i686-pc-windows-msvc.

try-job: x86_64-gnu-aux
@bors
Copy link
Collaborator

bors commented May 18, 2025

☀️ Try build successful - checks-actions
Build commit: 1777446 (177744690ff9c236ed94d4de85d63183f702c3ed)

@RalfJung
Copy link
Member Author

While we're at it I also enabled strict provenance enforcement for some of the tests -- we probably don't want to have int2ptr casts in the standard library. (miri-test-libstd already tests with that flag.)

@bors try

@bors
Copy link
Collaborator

bors commented May 22, 2025

⌛ Trying commit 8b7b026 with merge 3449d7b...

bors added a commit to rust-lang-ci/rust that referenced this pull request May 22, 2025
tools-aux ci runner: also cross-test doctests in Miri

Miri now supports running doctests across different targets. Let's use that to run the std doctests on aarch64-apple-darwin, i686-pc-windows-msvc.

try-job: x86_64-gnu-aux
@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented May 22, 2025

💔 Test failed - checks-actions

@RalfJung RalfJung force-pushed the miri-std-doctests branch from 8b7b026 to b9e6995 Compare May 22, 2025 08:09
@RalfJung
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request May 22, 2025
tools-aux ci runner: also cross-test doctests in Miri

Miri now supports running doctests across different targets. Let's use that to run the std doctests on aarch64-apple-darwin, i686-pc-windows-msvc.

try-job: x86_64-gnu-aux
@bors
Copy link
Collaborator

bors commented May 22, 2025

⌛ Trying commit b9e6995 with merge 8418ba9...

@bors
Copy link
Collaborator

bors commented May 22, 2025

☀️ Try build successful - checks-actions
Build commit: 8418ba9 (8418ba98707c96d9d8c43d30d3d5a4b3e5ea5088)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants