{aarch64,x86_64}-*-windows-gnullvm: build host tools #140772

mati865 · 2025-05-07T21:22:32Z

This will require MCP, but I suppose we need to know how long it takes to build first.

I opted for bootstrapping from Linux because that's the easiest host system to work with, but once this hits beta, having dedicated Windows runners would be sensible and probably preferable.

--enable-full-tools for whatever reason doesn't seem to work when cross-compiling, because LLVM tools for the new hosts are not copied into the expected directory. And WiX that bootstrap relies upon to create .msi installers only supports Windows. I haven't tried, but it might be usable via Wine.

Almost every commit is self-contained, so let me know if I should split them into separate PRs.

try-job: dist-aarch64-windows-gnullvm
try-job: dist-x86_64-windows-gnullvm

rustbot · 2025-05-07T21:22:37Z

r? @marcoieni

rustbot has assigned @marcoieni.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-05-07T21:22:39Z

This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp.

mati865 · 2025-05-11T21:12:03Z

Forgot to include try-job. Fixed it.

marcoieni · 2025-05-15T09:39:36Z

This will require MCP, but I suppose we need to know how long it takes to build first.

ok, so I guess we need to try this, right?

@bors try

{aarch64,x86_64}-*-windows-gnullvm: build host tools This will require MCP, but I suppose we need to know how long it takes to build first. I opted for bootstrapping from Linux because that's the easiest host system to work with, but once this hits beta, having dedicated Windows runners would be sensible and probably preferable. `--enable-full-tools` for whatever reason doesn't seem to work when cross-compiling, because LLVM tools for the new hosts are not copied into the expected directory. And WiX that bootstrap relies upon to create .msi installers only supports Windows. I haven't tried, but it might be usable via Wine. Almost every commit is self-contained, so let me know if I should split them into separate PRs. try-job: dist-windows-gnullvm

bors · 2025-05-15T09:45:16Z

⌛ Trying commit d0b81ca with merge 9772d67...

marcoieni · 2025-05-15T13:54:32Z

maybe you need to add the job to the src/ci/github-actions/jobs.yml file?

bors · 2025-05-15T15:45:16Z

💥 Test timed out

mati865 · 2025-05-15T19:29:31Z

Oh, right. Totally forgot about it.

marcoieni · 2025-05-16T09:27:44Z

@bors try

bors · 2025-05-16T09:29:10Z

⌛ Trying commit b256449 with merge 34c404a...

{aarch64,x86_64}-*-windows-gnullvm: build host tools This will require MCP, but I suppose we need to know how long it takes to build first. I opted for bootstrapping from Linux because that's the easiest host system to work with, but once this hits beta, having dedicated Windows runners would be sensible and probably preferable. `--enable-full-tools` for whatever reason doesn't seem to work when cross-compiling, because LLVM tools for the new hosts are not copied into the expected directory. And WiX that bootstrap relies upon to create .msi installers only supports Windows. I haven't tried, but it might be usable via Wine. Almost every commit is self-contained, so let me know if I should split them into separate PRs. try-job: dist-windows-gnullvm

bors · 2025-05-16T15:09:11Z

💔 Test failed - checks-actions

mati865 · 2025-05-16T16:24:42Z

System.IO.IOException: No space left on device

Unfortunately, free CI runners are not as capable as I had hoped. I've split the jobs now, but dunno if this will be acceptable.

marcoieni · 2025-05-19T14:41:01Z

I've split the jobs now, but dunno if this will be acceptable.

yes, we prefer multiple free runner compared to 1 large runner 👍

@bors try

{aarch64,x86_64}-*-windows-gnullvm: build host tools This will require MCP, but I suppose we need to know how long it takes to build first. I opted for bootstrapping from Linux because that's the easiest host system to work with, but once this hits beta, having dedicated Windows runners would be sensible and probably preferable. `--enable-full-tools` for whatever reason doesn't seem to work when cross-compiling, because LLVM tools for the new hosts are not copied into the expected directory. And WiX that bootstrap relies upon to create .msi installers only supports Windows. I haven't tried, but it might be usable via Wine. Almost every commit is self-contained, so let me know if I should split them into separate PRs. try-job: dist-aarch64-windows-gnullvm try-job: dist-x86_64-windows-gnullvm

bors · 2025-05-19T14:42:14Z

⌛ Trying commit a84e84e with merge 9e708f5...

bors · 2025-05-19T14:49:16Z

💔 Test failed - checks-actions

marcoieni · 2025-05-19T15:41:57Z

@bors try

…-compiling, r=cuviper rustc_llvm: add Windows system libs only when cross-compiling from Wi… …ndows This obviously doesn't work when cross-compiling from Linux. Split out from: rust-lang#140772 Fixes the issue described at [#general > Problems while trying to cross compile rustc for windows](https://rust-lang.zulipchat.com/#narrow/channel/122651-general/topic/Problems.20while.20trying.20to.20cross.20compile.20rustc.20for.20windows/with/520508561)

Rollup merge of #141817 - mati865:fix-system-libs-when-cross-compiling, r=cuviper rustc_llvm: add Windows system libs only when cross-compiling from Wi… …ndows This obviously doesn't work when cross-compiling from Linux. Split out from: #140772 Fixes the issue described at [#general > Problems while trying to cross compile rustc for windows](https://rust-lang.zulipchat.com/#narrow/channel/122651-general/topic/Problems.20while.20trying.20to.20cross.20compile.20rustc.20for.20windows/with/520508561)

…ndows This obviously doesn't work when cross-compiling from Linux. Split out from: rust-lang#140772

…indows, r=Kobzol Don't create .msi installer for gnullvm hosts WIX toolset works only on Windows hosts, but gnullvm doesn't have host toolchain yet. To get out of this loop, we will create a single release without MSI installer. Split out from: rust-lang#140772

Rollup merge of #141818 - mati865:dont-create-msi-from-non-windows, r=Kobzol Don't create .msi installer for gnullvm hosts WIX toolset works only on Windows hosts, but gnullvm doesn't have host toolchain yet. To get out of this loop, we will create a single release without MSI installer. Split out from: #140772

… tools

mati865 · 2025-06-11T23:17:31Z

@rustbot ready

All the changes not related to the jobs themselves are merged now (via separate PRs), so this should be good to go. I have added update llvm-mingw commit since the last time. I'll squash it when it's approved.

marcoieni · 2025-06-12T07:52:15Z

but once this hits beta, having dedicated Windows runners would be sensible and probably preferable.

mmh so you are saying that in a few weeks you are going to open a new PR to edit this code? Why not edit it now? 🤔

marcoieni · 2025-06-12T07:49:04Z

src/ci/github-actions/jobs.yml

@@ -237,6 +237,12 @@ auto:
  - name: dist-s390x-linux
    <<: *job-linux-4c

+  - name: dist-aarch64-windows-gnullvm
+    <<: *job-linux-4c


why not using the free arm runner instead of the x86 one?

marcoieni · 2025-06-12T07:49:51Z

src/ci/docker/host-x86_64/dist-aarch64-windows-gnullvm/Dockerfile

+# despite no such directory existing:
+# ❯ ls obj/dist-windows-gnullvm/build/aarch64-pc-windows-gnullvm/ -1
+#  llvm
+#  stage2


what character is this?

marcoieni · 2025-06-12T07:54:04Z

src/ci/docker/host-x86_64/dist-aarch64-windows-gnullvm/Dockerfile

+    --set llvm.download-ci-llvm=false \
+    --set rust.llvm-tools=false
+# LLVM cross tools are not installed into expected location so copying fails.
+# Probably will solve itself when building from Windows.


same question asked before. Why don't we build from windows now? Is it for the time required to change this PR and we want to ship this earlier? 🤔

marcoieni · 2025-06-12T08:01:20Z

src/ci/docker/host-x86_64/dist-aarch64-windows-gnullvm/Dockerfile

+# We are bootstrapping this target and cannot use previously built artifacts.
+# Without this option Clang is given `"-I/checkout/obj/build/aarch64-pc-windows-gnullvm/ci-llvm/include"`
+# despite no such directory existing:
+# ❯ ls obj/dist-windows-gnullvm/build/aarch64-pc-windows-gnullvm/ -1


Maybe it's more familiar to use $ instead of ❯ to indicate a prompt.

marcoieni · 2025-06-12T08:01:34Z

src/ci/docker/host-x86_64/dist-x86_64-windows-gnullvm/Dockerfile

+# ❯ ls obj/dist-windows-gnullvm/build/aarch64-pc-windows-gnullvm/ -1
+#  llvm
+#  stage2


same comments as above

marcoieni · 2025-06-12T08:02:33Z

src/ci/docker/host-x86_64/dist-x86_64-windows-gnullvm/install-llvm-mingw.sh

this file is very similar to [dist-aarch64-windows-gnullvm/install-llvm-mingw.sh](https://github.com/rust-lang/rust/pull/140772/files#diff-aa3918ad02d118bc5907a7d19827d8b3de442f35cde1b590b60261dee2852c07).

Can we share the logic somehow?

marcoieni · 2025-06-12T08:03:05Z

@bors2 try

rust-bors · 2025-06-12T08:03:09Z

⌛ Trying commit cacda77 with merge e70386e…

To cancel the try build, run the command @bors2 try cancel.

{aarch64,x86_64}-*-windows-gnullvm: build host tools This will require MCP, but I suppose we need to know how long it takes to build first. I opted for bootstrapping from Linux because that's the easiest host system to work with, but once this hits beta, having dedicated Windows runners would be sensible and probably preferable. `--enable-full-tools` for whatever reason doesn't seem to work when cross-compiling, because LLVM tools for the new hosts are not copied into the expected directory. And WiX that bootstrap relies upon to create .msi installers only supports Windows. I haven't tried, but it might be usable via Wine. Almost every commit is self-contained, so let me know if I should split them into separate PRs. try-job: dist-aarch64-windows-gnullvm try-job: dist-x86_64-windows-gnullvm

rust-bors · 2025-06-12T11:08:33Z

☀️ Try build successful (CI)
Build commit: e70386e (e70386ee53406b709646411f6d6f6ddd471514ef, parent: fe5c95d4ae33ec9d7831921e448e2daf8264ea42)

rustbot assigned marcoieni May 7, 2025

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 16, 2025

This comment has been minimized.

Sign in to view

Kivooeo pushed a commit to Kivooeo/rust that referenced this pull request Jun 3, 2025

rustc_llvm: add Windows system libs only when cross-compiling from Wi…

d8bf68b

…ndows This obviously doesn't work when cross-compiling from Linux. Split out from: rust-lang#140772

mati865 force-pushed the gnullvm-host branch 3 times, most recently from 9275937 to 13bfa7c Compare June 9, 2025 21:46

mati865 added 6 commits June 12, 2025 01:11

Move *-windows-gnullvm targets to it's own Dockerfile and enable host…

a7e39b2

… tools

Add CI job

f269a1b

Split CI into two jobs

f602369

fix paths after the split

120556b

Fix install script for AArch64

a3a585a

update llvm-mingw

cacda77

mati865 force-pushed the gnullvm-host branch from 13bfa7c to cacda77 Compare June 11, 2025 23:12

mati865 marked this pull request as ready for review June 11, 2025 23:12

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 11, 2025

marcoieni reviewed Jun 12, 2025

View reviewed changes

{aarch64,x86_64}-*-windows-gnullvm: build host tools #140772

Are you sure you want to change the base?

{aarch64,x86_64}-*-windows-gnullvm: build host tools #140772

Uh oh!

Conversation

mati865 commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented May 7, 2025

Uh oh!

rustbot commented May 7, 2025

Uh oh!

mati865 commented May 11, 2025

Uh oh!

marcoieni commented May 15, 2025

Uh oh!

bors commented May 15, 2025

Uh oh!

This comment has been minimized.

marcoieni commented May 15, 2025

Uh oh!

bors commented May 15, 2025

Uh oh!

mati865 commented May 15, 2025

Uh oh!

marcoieni commented May 16, 2025

Uh oh!

bors commented May 16, 2025

Uh oh!

This comment has been minimized.

bors commented May 16, 2025

Uh oh!

mati865 commented May 16, 2025

Uh oh!

marcoieni commented May 19, 2025

Uh oh!

bors commented May 19, 2025

Uh oh!

This comment has been minimized.

bors commented May 19, 2025

Uh oh!

marcoieni commented May 19, 2025

Uh oh!

mati865 commented Jun 11, 2025

Uh oh!

marcoieni commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marcoieni Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

marcoieni Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

marcoieni Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

marcoieni Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

marcoieni Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

marcoieni Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

marcoieni commented Jun 12, 2025

Uh oh!

rust-bors bot commented Jun 12, 2025

Uh oh!

rust-bors bot commented Jun 12, 2025

Uh oh!

Uh oh!

mati865 commented May 7, 2025 •

edited

Loading

marcoieni commented Jun 12, 2025 •

edited

Loading