-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Implement operations for Wrapping<T> where Rhs = T #140567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? libs-api |
Thanks for the PR! This comment explains why these impls were initially not provided: #93208 (comment). I think the rationale still holds, but I don't have a strong opinion either way. Adding the set of impls in this PR would make things slightly worse for some users and slightly better for some users. @rfcbot fcp close |
Team member @dtolnay has proposed to close this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
🔔 This is now entering its final comment period, as per the review above. 🔔 |
The final comment period, with a disposition to close, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. |
Currently doing the following is not possible:
It is however possible to do:
In the spirit of Is an RFC required? this seems like an obvious API hole. Therefore I've implemented this without an RFC. I am willing to write an RFC if it is required though.
I could not figure out where/how to implement tests for this, so if someone could please tell me where and how to do that.
Somewhat related issues: #91586 #32463