Describe lifetime of call argument temporaries passed indirectly

[tmiasko]

Fixes #132014.

[rustbot]

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rustbot]

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

[tmiasko]

r? codegen

[workingjubilee]

I wonder
@bors try @rust-timer queue

[bors]

⌛ Trying commit 653bbb9 with merge 9f0b7ad...

[bors]

☀️ Try build successful - checks-actions
Build commit: 9f0b7ad (9f0b7ad5494592153b6b7b686a00930bd3b8cf6d)

[rust-timer]

Finished benchmarking commit (9f0b7ad): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary 1.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.8%	[1.8%, 1.8%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.8%	[1.8%, 1.8%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: missing data
Artifact size: 365.54 MiB -> 365.55 MiB (0.00%)

[workingjubilee]

Cool. I was just checking for regressions in other cases.

[workingjubilee]

err, sorry for not kicking this back properly.

@bors author

[workingjubilee]

...
@rustbot author

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[tmiasko]

@rustbot ready

[workingjubilee]

Thanks!

@bors r+

[bors]

📌 Commit ed3d6c5 has been approved by workingjubilee

It is now in the queue for this repository.

[bors]

⌛ Testing commit ed3d6c5 with merge 12f3081...

[bors]

💔 Test failed - checks-actions

[tmiasko]

Configured opt-level in align-byval-alignment-mismatch test to avoid differences from bootstrap's optimize-tests option.

[workingjubilee]

uff

@bors r+

[bors]

📌 Commit 3b7ca28 has been approved by workingjubilee

It is now in the queue for this repository.

[bors]

⌛ Testing commit 3b7ca28 with merge 46264e6...

[bors]

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing 46264e6 to master...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 9f8929f (parent) -> 46264e6 (this PR)

Test differences

Show 4 test diffs

Stage 1

• [codegen] tests/codegen/call-tmps-lifetime.rs: [missing] -> pass (J1)
• [codegen] tests/codegen/issues/issue-98156-const-arg-temp-lifetime.rs: pass -> [missing] (J1)

Stage 2

• [codegen] tests/codegen/call-tmps-lifetime.rs: [missing] -> pass (J0)
• [codegen] tests/codegen/issues/issue-98156-const-arg-temp-lifetime.rs: pass -> [missing] (J0)

Job group index

• J0: aarch64-apple, aarch64-gnu, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, test-various, x86_64-apple-1, x86_64-gnu, x86_64-gnu-llvm-19-1, x86_64-gnu-llvm-19-2, x86_64-gnu-llvm-20-1, x86_64-gnu-llvm-20-2, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1
• J1: x86_64-gnu-llvm-19-3, x86_64-gnu-llvm-20-3

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 46264e6dfd8f0bacae05c520b4617e054d6ef990 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. dist-x86_64-apple: 7375.9s -> 9682.9s (31.3%)
2. dist-armv7-linux: 6550.8s -> 5225.0s (-20.2%)
3. aarch64-gnu-debug: 4935.0s -> 3985.5s (-19.2%)
4. dist-apple-various: 6210.1s -> 7001.8s (12.7%)
5. x86_64-apple-2: 4918.9s -> 5459.0s (11.0%)
6. x86_64-apple-1: 7805.2s -> 7268.8s (-6.9%)
7. dist-aarch64-apple: 4950.0s -> 5284.8s (6.8%)
8. x86_64-gnu-tools: 5951.6s -> 6332.2s (6.4%)
9. dist-various-2: 3189.1s -> 3391.1s (6.3%)
10. aarch64-apple: 3989.5s -> 4225.7s (5.9%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (46264e6): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 1.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.6%	[1.0%, 2.3%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 776.208s -> 776.159s (-0.01%)
Artifact size: 366.34 MiB -> 366.24 MiB (-0.03%)