Skip to content

improve type mutation for certain structures #134724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

onur-ozkan
Copy link
Member

self-explanatory

@rustbot
Copy link
Collaborator

rustbot commented Dec 24, 2024

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Dec 24, 2024
@rust-log-analyzer

This comment has been minimized.

self-explanatory

Signed-off-by: onur-ozkan <work@onurozkan.dev>
@jieyouxu
Copy link
Member

r? jieyouxu

@rustbot rustbot assigned jieyouxu and unassigned Kobzol Dec 24, 2024
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 24, 2024

📌 Commit 6b2fd4f has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 24, 2024
@bors
Copy link
Collaborator

bors commented Dec 24, 2024

⌛ Testing commit 6b2fd4f with merge d53b0ff...

@bors
Copy link
Collaborator

bors commented Dec 24, 2024

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing d53b0ff to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 24, 2024
@bors bors merged commit d53b0ff into rust-lang:master Dec 24, 2024
7 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 24, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d53b0ff): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.4% [0.4%, 0.4%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -2.7%, secondary 2.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.8% [2.1%, 3.5%] 2
Improvements ✅
(primary)
-2.7% [-3.1%, -2.1%] 3
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.7% [-3.1%, -2.1%] 3

Cycles

Results (secondary -5.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-5.2% [-5.5%, -5.0%] 3
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 761.878s -> 762.9s (0.13%)
Artifact size: 330.65 MiB -> 330.67 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants