-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Add new {x86_64,i686}-win7-windows-gnu targets
#134609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 35 additions & 0 deletions
35
compiler/rustc_target/src/spec/targets/i686_win7_windows_gnu.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| use crate::spec::{Cc, FramePointer, LinkerFlavor, Lld, Target, base}; | ||
|
|
||
| pub(crate) fn target() -> Target { | ||
| let mut base = base::windows_gnu::opts(); | ||
| base.vendor = "win7".into(); | ||
| base.cpu = "pentium4".into(); | ||
| base.max_atomic_width = Some(64); | ||
| base.frame_pointer = FramePointer::Always; // Required for backtraces | ||
| base.linker = Some("i686-w64-mingw32-gcc".into()); | ||
|
|
||
| // Mark all dynamic libraries and executables as compatible with the larger 4GiB address | ||
| // space available to x86 Windows binaries on x86_64. | ||
| base.add_pre_link_args(LinkerFlavor::Gnu(Cc::No, Lld::No), &[ | ||
| "-m", | ||
| "i386pe", | ||
| "--large-address-aware", | ||
| ]); | ||
| base.add_pre_link_args(LinkerFlavor::Gnu(Cc::Yes, Lld::No), &["-Wl,--large-address-aware"]); | ||
|
|
||
| Target { | ||
| llvm_target: "i686-pc-windows-gnu".into(), | ||
| metadata: crate::spec::TargetMetadata { | ||
| description: Some("32-bit MinGW (Windows 7+)".into()), | ||
| tier: Some(3), | ||
| host_tools: Some(false), | ||
| std: Some(true), | ||
| }, | ||
| pointer_width: 32, | ||
| data_layout: "e-m:x-p:32:32-p270:32:32-p271:32:32-p272:64:64-\ | ||
| i64:64-i128:128-f80:32-n8:16:32-a:0:32-S32" | ||
| .into(), | ||
| arch: "x86".into(), | ||
| options: base, | ||
| } | ||
| } |
32 changes: 32 additions & 0 deletions
32
compiler/rustc_target/src/spec/targets/x86_64_win7_windows_gnu.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| use crate::spec::{Cc, LinkerFlavor, Lld, Target, base}; | ||
|
|
||
| pub(crate) fn target() -> Target { | ||
| let mut base = base::windows_gnu::opts(); | ||
| base.vendor = "win7".into(); | ||
| base.cpu = "x86-64".into(); | ||
| base.plt_by_default = false; | ||
| // Use high-entropy 64 bit address space for ASLR | ||
| base.add_pre_link_args(LinkerFlavor::Gnu(Cc::No, Lld::No), &[ | ||
| "-m", | ||
| "i386pep", | ||
| "--high-entropy-va", | ||
| ]); | ||
| base.add_pre_link_args(LinkerFlavor::Gnu(Cc::Yes, Lld::No), &["-m64", "-Wl,--high-entropy-va"]); | ||
| base.max_atomic_width = Some(64); | ||
| base.linker = Some("x86_64-w64-mingw32-gcc".into()); | ||
|
|
||
| Target { | ||
| llvm_target: "x86_64-pc-windows-gnu".into(), | ||
| metadata: crate::spec::TargetMetadata { | ||
| description: Some("64-bit MinGW (Windows 7+)".into()), | ||
| tier: Some(3), | ||
| host_tools: Some(false), | ||
| std: Some(true), | ||
| }, | ||
| pointer_width: 64, | ||
| data_layout: | ||
| "e-m:w-p270:32:32-p271:32:32-p272:64:64-i64:64-i128:128-f80:128-n8:16:32:64-S128".into(), | ||
| arch: "x86_64".into(), | ||
| options: base, | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| # \*-win7-windows-gnu | ||
|
|
||
| **Tier: 3** | ||
|
|
||
| Windows targets continuing support of Windows 7. | ||
|
|
||
| Target triples: | ||
| - `i686-win7-windows-gnu` | ||
| - `x86_64-win7-windows-gnu` | ||
|
|
||
| ## Target maintainers | ||
|
|
||
| - @tbu- | ||
|
|
||
| ## Requirements | ||
|
|
||
| This target supports all of core, alloc, std and test. Host | ||
| tools may also work, though those are not currently tested. | ||
|
|
||
| Those targets follow Windows calling convention for extern "C". | ||
|
|
||
| Like any other Windows target, the created binaries are in PE format. | ||
|
|
||
| ## Building the target | ||
|
|
||
| You can build Rust with support for the targets by adding it to the target list in config.toml: | ||
|
|
||
| ```toml | ||
| [build] | ||
| build-stage = 1 | ||
| target = ["x86_64-win7-windows-gnu"] | ||
| ``` | ||
|
|
||
| ## Building Rust programs | ||
|
|
||
| Rust does not ship pre-compiled artifacts for this target. To compile for this | ||
| target, you will either need to build Rust with the target enabled (see | ||
| "Building the target" above), or build your own copy by using `build-std` or | ||
| similar. | ||
|
|
||
| ## Testing | ||
|
|
||
| Created binaries work fine on Windows or Wine using native hardware. Remote | ||
| testing is possible using the `remote-test-server` described [here](https://rustc-dev-guide.rust-lang.org/tests/running.html#running-tests-on-a-remote-machine). | ||
|
|
||
| ## Cross-compilation toolchains and C code | ||
|
|
||
| Compatible C code can be built with gcc's `{i686,x86_64}-w64-mingw32-gcc`. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.