Skip to content

Add support for different relocation models #13340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2014

Conversation

flaper87
Copy link
Contributor

@flaper87 flaper87 commented Apr 5, 2014

Rust currently defaults to RelocPIC regardless. This patch adds a new
codegen option that allows choosing different relocation-model. The
available models are:

- default (Use the target-specific default model)
- static
- pic
- no-pic

For a more detailed information use llc --help

@@ -36,6 +36,7 @@ _rustc_opts_switches=(
--target'[Target triple cpu-manufacturer-kernel\[-os\] to compile]'
--target-cpu'[Select target processor (llc -mcpu=help for details)]'
--target-feature'[Target specific attributes (llc -mattr=help for details)]'
--relocation-model'[Relocation model (llc --help for details)]'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the right format for the -C options?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. I think this file is outdated. However, I preferred to add it anyway to keep track of the config options. (Certainly rustc -C help would be better)

@alexcrichton
Copy link
Member

r=me if a test is added (just to exercise this code path)

Rust currently defaults to `RelocPIC` regardless. This patch adds a new
codegen option that allows choosing different relocation-model. The
available models are:

    - default (Use the target-specific default model)
    - static
    - pic
    - no-pic

For a more detailed information use `llc --help`
bors added a commit that referenced this pull request Apr 6, 2014
Rust currently defaults to `RelocPIC` regardless. This patch adds a new
codegen option that allows choosing different relocation-model. The
available models are:

    - default (Use the target-specific default model)
    - static
    - pic
    - no-pic

For a more detailed information use `llc --help`
@bors bors closed this Apr 6, 2014
@bors bors merged commit b78ac5b into rust-lang:master Apr 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants