Skip to content

Remove the crate map #13117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 26, 2014
Merged

Remove the crate map #13117

merged 3 commits into from
Mar 26, 2014

Conversation

alexcrichton
Copy link
Member

This can be done now that logging has been moved out and libnative is the default (not libgreen)

This is the final nail in the coffin for the crate map. The `start` function for
libgreen now has a new added parameter which is the event loop factory instead
of inferring it from the crate map. The two current valid values for this
parameter are `green::basic::event_loop` and `rustuv::event_loop`.
The crate map is no longer necessary now that logging and event loop factories
have been moved out.

Closes rust-lang#11617
Closes rust-lang#11731
This updates a few code examples about booting libgreen/libnative and also
spells out how the event loop factory is required.
@liigo
Copy link
Contributor

liigo commented Mar 25, 2014

Well done. But why not make eventloop as the last arg of green::start? So
both native::start and green::start have the same first three args, for
consistency.
2014年3月25日 上午1:54于 "Alex Crichton" notifications@github.com写道:

This can be done now that logging has been moved out and libnative is the

default (not libgreen)

You can merge this Pull Request by running

git pull https://github.com/alexcrichton/rust no-crate-map

Or view, comment on, or merge it at:

#13117
Commit Summary

  • green: Remove the dependence on the crate map
  • rustc: Remove all crate map support
  • doc: Update the runtime guide with green changes

File Changes

Patch Links:


Reply to this email directly or view it on GitHubhttps://github.com//pull/13117
.

bors added a commit that referenced this pull request Mar 26, 2014
This can be done now that logging has been moved out and libnative is the default (not libgreen)
@bors bors closed this Mar 26, 2014
@bors bors merged commit e2ae458 into rust-lang:master Mar 26, 2014
@alexcrichton alexcrichton deleted the no-crate-map branch March 26, 2014 17:22
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jul 25, 2024
…p-suggestion, r=Alexendoo

Fix wrong suggestion for `single_element_loop` where parens were missing

Fixes rust-lang/rust-clippy#12782.

changelog: Fix missing parens in `single_element_loop` suggestion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants