-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Remove the crate map #13117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the crate map #13117
Conversation
This is the final nail in the coffin for the crate map. The `start` function for libgreen now has a new added parameter which is the event loop factory instead of inferring it from the crate map. The two current valid values for this parameter are `green::basic::event_loop` and `rustuv::event_loop`.
The crate map is no longer necessary now that logging and event loop factories have been moved out. Closes rust-lang#11617 Closes rust-lang#11731
This updates a few code examples about booting libgreen/libnative and also spells out how the event loop factory is required.
Well done. But why not make eventloop as the last arg of green::start? So
|
This can be done now that logging has been moved out and libnative is the default (not libgreen)
…p-suggestion, r=Alexendoo Fix wrong suggestion for `single_element_loop` where parens were missing Fixes rust-lang/rust-clippy#12782. changelog: Fix missing parens in `single_element_loop` suggestion
This can be done now that logging has been moved out and libnative is the default (not libgreen)