Skip to content

make FileStat hashable, and Paths serializable #12822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 13, 2014
Merged

Conversation

erickt
Copy link
Contributor

@erickt erickt commented Mar 11, 2014

This PR makes std::io::FileStat hashable, and Path serializable as a byte array.

@erickt
Copy link
Contributor Author

erickt commented Mar 12, 2014

@alexcrichton: I got a little unlucky and it seems your comment got lost here too. Does it look still look good?

bors added a commit that referenced this pull request Mar 13, 2014
This PR makes `std::io::FileStat` hashable, and `Path` serializable as a byte array.
@bors bors closed this Mar 13, 2014
@bors bors merged commit 62026fd into rust-lang:master Mar 13, 2014
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jun 13, 2024
Make `for_each_expr` visit closures by default, rename the old version `for_each_expr_without_closures`

A lot of the time `for_each_expr` is picked when closures should be visited so I think it makes sense for this to be the default with the alternative available for when you don't need to visit them.

The first commit renames `for_each_expr` to `for_each_expr_without_closures` and `for_each_expr_with_closures` to `for_each_expr`

The second commit switches a few uses that I caught over to include closures to fix a few bugs

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants