Skip to content

Update rustc-perf #125502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2024
Merged

Update rustc-perf #125502

merged 1 commit into from
May 25, 2024

Conversation

weihanglo
Copy link
Member

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels May 24, 2024
@weihanglo
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented May 24, 2024

⌛ Trying commit 01d08cd with merge e37ce49...

@bors
Copy link
Collaborator

bors commented May 24, 2024

☀️ Try build successful - checks-actions
Build commit: e37ce49 (e37ce490acfb2a567af0937a14fc1eae5e015312)

@Kobzol
Copy link
Contributor

Kobzol commented May 24, 2024

@rust-timer build e37ce49

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e37ce49): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -4.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.9% [-4.9%, -4.9%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 673.59s -> 674.271s (0.10%)
Artifact size: 315.74 MiB -> 315.69 MiB (-0.01%)

@weihanglo
Copy link
Member Author

weihanglo commented May 24, 2024

Instruction count
Compile-time: No results

Something went wrong, right?

@Kobzol
Copy link
Contributor

Kobzol commented May 24, 2024

No, everything seems fine :) Just no relevant differences were found.

@weihanglo weihanglo force-pushed the update-rustc-perf branch from 01d08cd to 99c9b07 Compare May 24, 2024 21:57
@weihanglo weihanglo marked this pull request as ready for review May 24, 2024 21:57
@weihanglo weihanglo changed the title [DONT MERGE] Update rustc-perf Update rustc-perf May 24, 2024
@weihanglo
Copy link
Member Author

Okay thanks! I guess we're ready to bump this before the diff becomes too big?

@Kobzol
Copy link
Contributor

Kobzol commented May 25, 2024

I don't think that we really need to update rustc-perf, there haven't been any relevant changes as far as I remember, but it also shouldn't hurt. So if you want to update it, feel free to r=me.

@weihanglo
Copy link
Member Author

there haven't been any relevant changes as far as I remember

That's true. I am doing this because we might have some more changes (license update from our git dependencies, and a potential new --cargo-config flag) in the future, so better checking if it can be merged and merge it now.

Thanks for the review! I am going to merge :)

@bors r=Kobzol

@bors
Copy link
Collaborator

bors commented May 25, 2024

📌 Commit 99c9b07 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 25, 2024
@bors
Copy link
Collaborator

bors commented May 25, 2024

⌛ Testing commit 99c9b07 with merge 14562dd...

@bors
Copy link
Collaborator

bors commented May 25, 2024

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 14562dd to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 25, 2024
@bors bors merged commit 14562dd into rust-lang:master May 25, 2024
7 checks passed
@rustbot rustbot added this to the 1.80.0 milestone May 25, 2024
@weihanglo weihanglo deleted the update-rustc-perf branch May 25, 2024 18:01
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (14562dd): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.0% [1.0%, 1.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary -2.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.8% [-2.8%, -2.8%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 670.899s -> 671.46s (0.08%)
Artifact size: 315.55 MiB -> 315.58 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants