-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Update rustc-perf #125502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rustc-perf #125502
Conversation
@bors try |
[DONT MERGE] Update rustc-perf Just check if the latest commit works. rust-lang/rustc-perf@4f313ad...cc81f96 See discussion on Zulip: https://rust-lang.zulipchat.com/#narrow/stream/247081-t-compiler.2Fperformance/topic/tempfile.20in.20rustc-perf.20make.20it.20hard.20to.20configure.20vendor/near/440442827 r? ghost
☀️ Try build successful - checks-actions |
@rust-timer build e37ce49 |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (e37ce49): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary -4.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 673.59s -> 674.271s (0.10%) |
Something went wrong, right? |
No, everything seems fine :) Just no relevant differences were found. |
01d08cd
to
99c9b07
Compare
Okay thanks! I guess we're ready to bump this before the diff becomes too big? |
I don't think that we really need to update rustc-perf, there haven't been any relevant changes as far as I remember, but it also shouldn't hurt. So if you want to update it, feel free to r=me. |
That's true. I am doing this because we might have some more changes (license update from our git dependencies, and a potential new Thanks for the review! I am going to merge :) @bors r=Kobzol |
☀️ Test successful - checks-actions |
Finished benchmarking commit (14562dd): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (secondary -2.8%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 670.899s -> 671.46s (0.08%) |
Just check if the latest commit works.
rust-lang/rustc-perf@4f313ad...cc81f96
See discussion on Zulip: https://rust-lang.zulipchat.com/#narrow/stream/247081-t-compiler.2Fperformance/topic/tempfile.20in.20rustc-perf.20make.20it.20hard.20to.20configure.20vendor/near/440442827
r? ghost