Skip to content

Fix the assertion crash from rustdoc document indent widths #124431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2024
Merged

Fix the assertion crash from rustdoc document indent widths #124431

merged 1 commit into from
Apr 28, 2024

Conversation

chenyukang
Copy link
Member

Fixes #124363

@rustbot
Copy link
Collaborator

rustbot commented Apr 27, 2024

r? @Nadrieril

rustbot has assigned @Nadrieril.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Apr 27, 2024
Nadrieril
Nadrieril reviewed Apr 27, 2024
View reviewed changes
@chenyukang chenyukang force-pushed the yukang-fix-rustdoc-124363 branch from 0924d80 to 6faedd3 Compare April 28, 2024 03:17
@Nadrieril
Copy link
Member

Thank you!

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 28, 2024

📌 Commit 6faedd3 has been approved by Nadrieril

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 28, 2024
@bors
Copy link
Collaborator

bors commented Apr 28, 2024

⌛ Testing commit 6faedd3 with merge 1fffb2a...

@bors
Copy link
Collaborator

bors commented Apr 28, 2024

☀️ Test successful - checks-actions
Approved by: Nadrieril
Pushing 1fffb2a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 28, 2024
@bors bors merged commit 1fffb2a into rust-lang:master Apr 28, 2024
11 checks passed
@rustbot rustbot added this to the 1.80.0 milestone Apr 28, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1fffb2a): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 673.47s -> 674.021s (0.08%)
Artifact size: 315.96 MiB -> 316.00 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nadrieril Nadrieril Nadrieril left review comments

Assignees

@Nadrieril Nadrieril

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.80.0
Development

Successfully merging this pull request may close these issues.

ICE: rustdoc: line.len() >= frag.indent
5 participants
@chenyukang @rustbot @Nadrieril @bors @rust-timer