Skip to content

[experiment] check-aux: test core and alloc in Miri #123560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

[experiment] check-aux: test core and alloc in Miri #123560

wants to merge 9 commits into from

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Apr 6, 2024

Just a 2nd branch parallel to #123506 so that I can run two CI time measurements at the same time.

@rustbot
Copy link
Collaborator

rustbot commented Apr 6, 2024

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 6, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@RalfJung RalfJung force-pushed the miri-test-libstd2 branch from 7389535 to 1bc94a7 Compare April 6, 2024 19:31
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@RalfJung RalfJung force-pushed the miri-test-libstd2 branch from 1bc94a7 to 72e2538 Compare April 7, 2024 05:30
@RalfJung RalfJung force-pushed the miri-test-libstd2 branch from 72e2538 to 7c76d34 Compare April 7, 2024 07:59
@RalfJung
Copy link
Member Author

RalfJung commented Apr 7, 2024

Let's see how much enabling overflow checks (but not other debug assertions) costs. The baseline is 104min for the gnu-aux job.

@RalfJung
Copy link
Member Author

RalfJung commented Apr 7, 2024

Looks like overflow checks costs around 9 minutes.

For comparison, what do just debug assertions cost?

@RalfJung RalfJung force-pushed the miri-test-libstd2 branch from 7c76d34 to 24ea7bc Compare April 7, 2024 09:58
@RalfJung RalfJung mentioned this pull request Apr 7, 2024
Merged
@RalfJung
Copy link
Member Author

RalfJung commented Apr 7, 2024

Around 30min. All right, experiment over.

@RalfJung RalfJung closed this Apr 7, 2024
@RalfJung RalfJung deleted the miri-test-libstd2 branch April 7, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@clubby789 clubby789

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RalfJung @rustbot @rust-log-analyzer @clubby789