Move concurrent stuff from lib extra on a separate package #11910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
|
|
||
| #[allow(missing_doc)]; | ||
| #[feature(globs)]; |
There was a problem hiding this comment.
Would it be possible to remove this feature? If it's super painful, then we can leave it, but in general it'd be nice if the smaller crates didn't have lots of extra features.
|
This is pretty awesome, thanks! I feel like the name concurrency is a little too long for a crate name. I was thinking this would be called What do you think of that? |
|
FWIW, I agree w/ @alexcrichton about |
Change concurrency to sync, remove extra features, update comments (remove extern mod …).
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 18, 2024
…ndomDev99 fix: incorrect suggestions when `.then` and `.then_some` is used fixes rust-lang#11910 In the current implementation of `search_is_some`, if a `.is_none` call is followed by a `.then` or `.then_some` call, the generated `!` will incorrectly negate the values returned by the `then` and `.then_some` calls. To fix this, we need to add parentheses to the generated suggestions when appropriate. changelog: [`search_is_some`]: add parenthesis to suggestions when appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some work for #8784.
Move extra::arc, extra::sync, extra::future, extra::task_pool and extra::comm in libconcurrency.
maybe the name lib concurrency is not really good, but i can change this.