mk: Fix llvmdeps.rs dependencies #11292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a multi-host build the mklldeps.py tool is getting called before all the llvm-configs are built. I am not actually sure the cause. I had convinced myself that DEF_LLVM_RULES needed to be called before the llvmdeps.rs rule, but now looking at it again I can't see why.
|
Oh, maybe this doesn't fix the problem. Let me test a little harder. |
|
It does seem to fix it. |
bors
added a commit
that referenced
this pull request
Jan 4, 2014
In a multi-host build the mklldeps.py tool is getting called before all the llvm-configs are built. I am not actually sure the cause. I had convinced myself that DEF_LLVM_RULES needed to be called before the llvmdeps.rs rule, but now looking at it again I can't see why. Here's the error: http://buildbot.rust-lang.org/builders/dist2-linux/builds/11/steps/compile/logs/stdio r? @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a multi-host build the mklldeps.py tool is getting called before
all the llvm-configs are built. I am not actually sure the cause. I
had convinced myself that DEF_LLVM_RULES needed to be called before
the llvmdeps.rs rule, but now looking at it again I can't see why.
Here's the error: http://buildbot.rust-lang.org/builders/dist2-linux/builds/11/steps/compile/logs/stdio
r? @alexcrichton