Skip to content

Remove optimal xz settings from CI #109888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

Mark-Simulacrum
Copy link
Member

This is a companion PR to rust-lang/promote-release#58, which moves the relevant optimal code to rust-lang/promote-release. As mentioned in the comments of that PR, this is expected to cut CI costs (and time, though predominantly felt on fast builders) and reduce wasted resources due to in-practice single-threaded compression not using the full 8+ vCPU builders we have available.

This probably shouldn't land before that PR + a simpleinfra change to enable the recompression of xz artifacts. But if it does land, it's just a matter of a few nightlies with slightly larger artifacts, so not a big deal.

r? @pietroalbini

This is a companion PR to rust-lang/promote-release#58, which moves the
relevant optimal code to rust-lang/promote-release. As mentioned in the
comments of that PR, this is expected to cut CI costs (and time, though
predominantly felt on fast builders) and reduce wasted resources due to
in-practice single-threaded compression not using the full 8+ vCPU
builders we have available.
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Apr 3, 2023
@Mark-Simulacrum
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented Apr 3, 2023

⌛ Trying commit 0da526b with merge c7d503a4986575621b97e3ec5e7e5403c4f9d55c...

@bors
Copy link
Collaborator

bors commented Apr 3, 2023

☀️ Try build successful - checks-actions
Build commit: c7d503a4986575621b97e3ec5e7e5403c4f9d55c (c7d503a4986575621b97e3ec5e7e5403c4f9d55c)

@pietroalbini
Copy link
Member

r=me

@Mark-Simulacrum
Copy link
Member Author

@bors r=pietroalbini rollup=iffy

promote-release should recompress back to small sizes now that rust-lang/promote-release#58 has landed, so this should be good to go.

@bors
Copy link
Collaborator

bors commented Apr 3, 2023

📌 Commit 0da526b has been approved by pietroalbini

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 3, 2023
@Mark-Simulacrum
Copy link
Member Author

@bors rollup=never - want to avoid putting this in a rollup actually, to give a clear step on timings

@bors
Copy link
Collaborator

bors commented Apr 4, 2023

⌛ Testing commit 0da526b with merge bd991d9...

@bors
Copy link
Collaborator

bors commented Apr 4, 2023

☀️ Test successful - checks-actions
Approved by: pietroalbini
Pushing bd991d9 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 4, 2023
@bors bors merged commit bd991d9 into rust-lang:master Apr 4, 2023
@rustbot rustbot added this to the 1.70.0 milestone Apr 4, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (bd991d9): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.1% [3.1%, 3.1%] 1
Improvements ✅
(primary)
-1.0% [-1.0%, -1.0%] 1
Improvements ✅
(secondary)
-2.1% [-3.1%, -1.2%] 2
All ❌✅ (primary) -1.0% [-1.0%, -1.0%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

@Mark-Simulacrum Mark-Simulacrum deleted the balanced-compression branch April 4, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants