-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Still-further-specializable projections are ambiguous in new solver #109619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bors
merged 2 commits into
rust-lang:master
from
compiler-errors:new-solver-still-further-specializable
Mar 26, 2023
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
// compile-flags: -Ztrait-solver=next | ||
|
||
#![feature(specialization)] | ||
//~^ WARN the feature `specialization` is incomplete | ||
|
||
trait Default { | ||
type Id; | ||
|
||
fn intu(&self) -> &Self::Id; | ||
} | ||
|
||
impl<T> Default for T { | ||
default type Id = T; | ||
|
||
fn intu(&self) -> &Self::Id { | ||
self | ||
//~^ ERROR cannot satisfy `T <: <T as Default>::Id` | ||
} | ||
} | ||
|
||
fn transmute<T: Default<Id = U>, U: Copy>(t: T) -> U { | ||
*t.intu() | ||
} | ||
|
||
use std::num::NonZeroU8; | ||
fn main() { | ||
let s = transmute::<u8, Option<NonZeroU8>>(0); | ||
//~^ ERROR cannot satisfy `<u8 as Default>::Id == Option<NonZeroU8> | ||
assert_eq!(s, None); | ||
} |
31 changes: 31 additions & 0 deletions
31
tests/ui/traits/new-solver/specialization-transmute.stderr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
warning: the feature `specialization` is incomplete and may not be safe to use and/or cause compiler crashes | ||
--> $DIR/specialization-transmute.rs:3:12 | ||
| | ||
LL | #![feature(specialization)] | ||
| ^^^^^^^^^^^^^^ | ||
| | ||
= note: see issue #31844 <https://github.com/rust-lang/rust/issues/31844> for more information | ||
= help: consider using `min_specialization` instead, which is more stable and complete | ||
= note: `#[warn(incomplete_features)]` on by default | ||
|
||
error[E0284]: type annotations needed: cannot satisfy `T <: <T as Default>::Id` | ||
--> $DIR/specialization-transmute.rs:16:9 | ||
| | ||
LL | self | ||
| ^^^^ cannot satisfy `T <: <T as Default>::Id` | ||
|
||
error[E0284]: type annotations needed: cannot satisfy `<u8 as Default>::Id == Option<NonZeroU8>` | ||
--> $DIR/specialization-transmute.rs:27:13 | ||
| | ||
LL | let s = transmute::<u8, Option<NonZeroU8>>(0); | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot satisfy `<u8 as Default>::Id == Option<NonZeroU8>` | ||
| | ||
note: required by a bound in `transmute` | ||
--> $DIR/specialization-transmute.rs:21:25 | ||
| | ||
LL | fn transmute<T: Default<Id = U>, U: Copy>(t: T) -> U { | ||
| ^^^^^^ required by this bound in `transmute` | ||
|
||
error: aborting due to 2 previous errors; 1 warning emitted | ||
|
||
For more information about this error, try `rustc --explain E0284`. |
22 changes: 22 additions & 0 deletions
22
tests/ui/traits/new-solver/specialization-unconstrained.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
// compile-flags: -Ztrait-solver=next | ||
|
||
#![feature(specialization)] | ||
//~^ WARN the feature `specialization` is incomplete | ||
|
||
// Do not treat the RHS of a projection-goal as an unconstrained `Certainty::Yes` response | ||
// if the impl is still further specializable. | ||
|
||
trait Default { | ||
type Id; | ||
} | ||
|
||
impl<T> Default for T { | ||
default type Id = T; | ||
} | ||
|
||
fn test<T: Default<Id = U>, U>() {} | ||
|
||
fn main() { | ||
test::<u32, ()>(); | ||
//~^ ERROR cannot satisfy `<u32 as Default>::Id == ()` | ||
} |
25 changes: 25 additions & 0 deletions
25
tests/ui/traits/new-solver/specialization-unconstrained.stderr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
warning: the feature `specialization` is incomplete and may not be safe to use and/or cause compiler crashes | ||
--> $DIR/specialization-unconstrained.rs:3:12 | ||
| | ||
LL | #![feature(specialization)] | ||
| ^^^^^^^^^^^^^^ | ||
| | ||
= note: see issue #31844 <https://github.com/rust-lang/rust/issues/31844> for more information | ||
= help: consider using `min_specialization` instead, which is more stable and complete | ||
= note: `#[warn(incomplete_features)]` on by default | ||
|
||
error[E0284]: type annotations needed: cannot satisfy `<u32 as Default>::Id == ()` | ||
--> $DIR/specialization-unconstrained.rs:20:5 | ||
| | ||
LL | test::<u32, ()>(); | ||
| ^^^^^^^^^^^^^^^ cannot satisfy `<u32 as Default>::Id == ()` | ||
| | ||
note: required by a bound in `test` | ||
--> $DIR/specialization-unconstrained.rs:17:20 | ||
| | ||
LL | fn test<T: Default<Id = U>, U>() {} | ||
| ^^^^^^ required by this bound in `test` | ||
|
||
error: aborting due to previous error; 1 warning emitted | ||
|
||
For more information about this error, try `rustc --explain E0284`. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.