rustdoc: make item links consistently use title="{shortty} {path}"
#107242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ordering in item tables was flipped in 3030cbe, making it inconsistent with the ordering in method signatures. Compare these: https://github.com/rust-lang/rust/blob/c8e6a9e8b6251bbc8276cb78cabe1998deecbed7/src/librustdoc/html/render/print_item.rs#L455-L459 https://github.com/rust-lang/rust/blob/c8e6a9e8b6251bbc8276cb78cabe1998deecbed7/src/librustdoc/html/format.rs#L903-L908
|
r? @jsha (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
GuillaumeGomez
approved these changes
Jan 26, 2023
|
It indeed makes more sense, thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jan 27, 2023
…, r=GuillaumeGomez
rustdoc: make item links consistently use `title="{shortty} {path}"`
The ordering in item tables was flipped in 3030cbe, making it inconsistent with the ordering in method signatures.
Compare these (before this PR is merged):
https://github.com/rust-lang/rust/blob/c8e6a9e8b6251bbc8276cb78cabe1998deecbed7/src/librustdoc/html/render/print_item.rs#L455-L459
https://github.com/rust-lang/rust/blob/c8e6a9e8b6251bbc8276cb78cabe1998deecbed7/src/librustdoc/html/format.rs#L903-L908
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 27, 2023
Rollup of 8 pull requests Successful merges: - rust-lang#105784 (update stdarch) - rust-lang#106856 (core: Support variety of atomic widths in width-agnostic functions) - rust-lang#107171 (rustc_metadata: Fix `encode_attrs`) - rust-lang#107242 (rustdoc: make item links consistently use `title="{shortty} {path}"`) - rust-lang#107279 (Use new solver during selection) - rust-lang#107284 (rustdoc: use smarter encoding for playground URL) - rust-lang#107325 (rustdoc: Stop using `HirId`s) - rust-lang#107336 (rustdoc: remove mostly-unused CSS classes `import-item` and `module-item`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ordering in item tables was flipped in 3030cbe, making it inconsistent with the ordering in method signatures.
Compare these (before this PR is merged):
rust/src/librustdoc/html/render/print_item.rs
Lines 455 to 459 in c8e6a9e
rust/src/librustdoc/html/format.rs
Lines 903 to 908 in c8e6a9e