Add benchmark tests to path/posix #10691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have written some benchmark tests to `push`, `push_many`, `join`, `join_many` and `ends_with_path`.
|
These look good, but I'm a bit worried that LLVM will optimize these right out. When you run the benchmarks, does it show them as taking a non-zero time? (You can do this with |
bors
added a commit
that referenced
this pull request
Nov 28, 2013
I have written some benchmark tests to `push`, `push_many`, `join`, `join_many` and `ends_with_path`. Let me know what you think (@cmr). Thanks in advance.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
May 20, 2023
…archo fix: warn on empty line outer AttrKind::DocComment changelog: [`empty_line_after_doc_comments`]: add lint for checking empty lines after rustdoc comments. Fixes: rust-lang#10395
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have written some benchmark tests to
push,push_many,join,join_manyandends_with_path.Let me know what you think (@cmr).
Thanks in advance.