Skip to content

rustdoc: use the regular arrow indicator for dir-entry CSS #106301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 2, 2023

Conversation

notriddle
Copy link
Contributor

This mostly reverts 468acca, while still fixing the problem it fixed by using an internal list-style-position. It results in a slight change in the hover indicator, but nothing misleading.

Preview: http://notriddle.com/notriddle-rustdoc-demos/dir-entry/src/std/lib.rs.html

Before

image

After

image

This mostly reverts 468acca, while still
fixing the problem it fixed by using an internal list-style-position. It
results in a slight change in the hover indicator, but nothing misleading.
@rustbot
Copy link
Collaborator

rustbot commented Dec 30, 2022

r? @jsha

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Dec 30, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 30, 2022

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@GuillaumeGomez
Copy link
Member

Then please add a test for the position of the element after the arrow in parent and sub element and in both mobile and desktop.

@notriddle
Copy link
Contributor Author

@GuillaumeGomez Okay, test case added for the size and styling of the dir-entry summary.

@GuillaumeGomez
Copy link
Member

You forgot the position (both x and y) to ensure the parent and its child(ren) have the expected layout (small x and y offset for the child(ren)).

@notriddle notriddle force-pushed the notriddle/dir-entry branch from 0e32ab9 to 399fe5d Compare January 2, 2023 02:52
@notriddle
Copy link
Contributor Author

@GuillaumeGomez Okay, new test assertions added for the x and y positions.

@GuillaumeGomez
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 2, 2023

📌 Commit 399fe5d has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 2, 2023
@bors
Copy link
Collaborator

bors commented Jan 2, 2023

⌛ Testing commit 399fe5d with merge f89003e...

@bors
Copy link
Collaborator

bors commented Jan 2, 2023

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing f89003e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 2, 2023
@bors bors merged commit f89003e into rust-lang:master Jan 2, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 2, 2023
@notriddle notriddle deleted the notriddle/dir-entry branch January 2, 2023 14:38
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f89003e): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.3% [-0.3%, -0.3%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.3% [-0.3%, -0.3%] 1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.0% [4.0%, 4.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants