-
Notifications
You must be signed in to change notification settings - Fork 13.4k
rustdoc: use the regular arrow indicator for dir-entry CSS #106301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This mostly reverts 468acca, while still fixing the problem it fixed by using an internal list-style-position. It results in a slight change in the hover indicator, but nothing misleading.
r? @jsha (rustbot has picked a reviewer for you, use r? to override) |
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
Then please add a test for the position of the element after the arrow in parent and sub element and in both mobile and desktop. |
88ec4c0
to
0e32ab9
Compare
@GuillaumeGomez Okay, test case added for the size and styling of the dir-entry summary. |
You forgot the position (both |
0e32ab9
to
399fe5d
Compare
@GuillaumeGomez Okay, new test assertions added for the x and y positions. |
Thanks! @bors r+ rollup |
☀️ Test successful - checks-actions |
Finished benchmarking commit (f89003e): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
This mostly reverts 468acca, while still fixing the problem it fixed by using an internal list-style-position. It results in a slight change in the hover indicator, but nothing misleading.
Preview: http://notriddle.com/notriddle-rustdoc-demos/dir-entry/src/std/lib.rs.html
Before
After