Skip to content

make tidy: skip check for binaries if /proc/version contains the string Microsoft #36706

Closed
@ahicks92

Description

@ahicks92

If developing under Windows Subsystemm for Linux, make tidy mistakenly believes that all source files are binaries. Per @eddyb's comment in #36151, this is likely to be because all files on the Windows filesystem are exposed with permissions 777.

We can detect that a system is likely to be WSl by checking /proc/version for the string Microsoft. should Microsoft ever change this file to not use this string, the worst that happens here is a regression. It is possible that other Linux systems include the string Microsoft in /proc/version, but this seems unlikely.

The specific problem here is twofold: make tidy prints binary checked into source for every single file in the repository, and make check refuses to run because make tidy fails. I'm not familiar enough with the Rust build system to even begin to attempt to fix this myself.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions