Skip to content

Fix issue-506.rs by adding a void-returning stub in the runtime. #2957

Closed
@bblum

Description

@bblum

In preparation for removing unsupervise() from the runtime, I had to replace calls to it with calls to something else in all the test cases. But the test for issue #506 needs a fn(), and there are no such functions left in the runtime builtins with unsupervise gone.

The hack I pulled to use get_task_id instead worked on all platforms but darwin, where it compiled to get the return value by reference instead of in a register.

Adding a wrapper wouldn't work because the test case's intent is to call the function directly. This probably requires a snapshot.

Currently xfailed on all platforms.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-runtimeArea: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflowsA-testsuiteArea: The testsuite used to check the correctness of rustcC-cleanupCategory: PRs that clean code up or issues documenting cleanup.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions