Skip to content

Remove build date from --version #25812

Closed
@brson

Description

@brson

I added this some months ago because I thought it would help stem confusion about the reported commit date when it happens to be a few days behind the release artifacts. I no longer think this is a great idea for two reasons:

  1. This date is not guaranteed to be the same across platforms. There have been occasions when the builds were spread across multiple days. Because these strings are not guaranteed to be the same one can't compare the output of two rustc --version invocations to check for equivalence, which is something I have wanted to do (I think one of my tools has to frob this string to eliminate the build date). Fixing this would require more complexity in the buildbot config than I'm comfortable with atm.

  2. The commit date for nightlies should never actually be more than 1-2 days behind the distribution date since the head commit is always a merge commit. The original motivation for adding the build date may not have been very strong.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions