getopt error with single character options

[mcandre]

getopt works fine for long options, but borks on short options. I've tried multiple syntaxes, including Unix and Windows CLI conventions; the docs don't even suggest which one Rust getopt expects.

Code:

https://github.com/mcandre/ios7crypt/tree/master/rust

Trace:

$ make

$ ./ios7crypt --encrypt monkey
082c4340021c1c

$ ./ios7crypt -e monkey
rust: upcall fail 'bounds check', src/libstd/getopts.rs:314
rust: domain main @0x7ff608817600 root task failed

$ ./ios7crypt -emonkey
rust: upcall fail 'Argument to option 'e' missing.', ios7crypt.rs:115
rust: domain main @0x7f8dda017600 root task failed

$ ./ios7crypt -e=monkey
rust: upcall fail 'Argument to option 'e' missing.', ios7crypt.rs:115
rust: domain main @0x7fd3fa017600 root task failed

$ ./ios7crypt --e monkey
rust: upcall fail 'Unrecognized option: 'e'.', ios7crypt.rs:115
rust: domain main @0x7fe853816200 root task failed

$ ./ios7crypt /e monkey
Usage: ./ios7crypt [options]
-e --encrypt <password> Encrypt
-d --decrypt <hash> Decrypt
-t --test       Unit test
-h --help       Usage

$ ./ios7crypt /e:monkey
Usage: ./ios7crypt [options]
-e --encrypt <password> Encrypt
-d --decrypt <hash> Decrypt
-t --test       Unit test
-h --help       Usage

$ ./ios7crypt /e=monkey
Usage: ./ios7crypt [options]
-e --encrypt <password> Encrypt
-d --decrypt <hash> Decrypt
-t --test       Unit test
-h --help       Usage

It seems that getopt expects -e monkey syntax, but experiences an internal error:

rust: upcall fail 'bounds check', src/libstd/getopts.rs:314

[graydon]

Sorry for the slow reply. The issue here has to do with your code actually, but it's a bit non-obvious. You're testing whether the options "e" or "encrypt" are given, then only retrieving the option called "encrypt". When only "e" is given, the condition passes but the retrieval fails. The getopts module doesn't automatically guess that "e" and "encrypt" are synonymous.

However, writing code that uses it that way is a bit convoluted (you wind up with a nesting of the condition again within the extraction clause) so I've taken the liberty of adding convenience functions to getopts that retrieve option strings by list of synonymous options. This lets you request opts_str(match, ["e", "encrypt"]) and get back the singular match. Hopefully this is enough.

Pushing these additions momentarily.