Skip to content

compiletest: consider transitioning //@ only-* target-based directives to e.g. //@ only-target_arch: arch1 arch2 #140575

Open
@jieyouxu

Description

@jieyouxu

Which allows permitting e.g. both aarch64 + x86_64. Currently

//@ only-x86_64
//@ only-aarch64

means the test will never run, since this is AND of x86_64 + aarch64 target archs.

Also might want to consider detecting "test will never run" directive combos.

Blocked: don't pile on hacks, name-value directive parsing in compiletest desperately needs cleanup.

Metadata

Metadata

Assignees

Labels

A-compiletestArea: The compiletest test runnerC-enhancementCategory: An issue proposing an enhancement or a PR with one.S-blockedStatus: Blocked on something else such as an RFC or other implementation work.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Type

No type

Projects

Status

Backlog

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions