New linker error when building diesel with rust-beta on windows

[weiznich]

Code

I tried this code: https://github.com/diesel-rs/diesel/tree/2.2.x (2464571)

I'm using the following command to execute tests: cargo +beta test --manifest-path diesel_derives/Cargo.toml --no-default-features --features "diesel/mysql mysql"

I expected to see this happen: Code compiles successful and tests complete (Link to the relevant CI run)

Instead, this happened: Code fails to compile with a linking error on windows (other systems work fine):

  = note:    Creating library D:\a\diesel\diesel\target\debug\deps\tests-1cc142ef763bf67a.lib and object D:\a\diesel\diesel\target\debug\deps\tests-1cc142ef763bf67a.exp␍
          mysqlclient.lib(my_init.obj) : error LNK2019: unresolved external symbol __imp_RegCloseKey referenced in function "bool __cdecl win32_have_tcpip(void)" (?win32_have_tcpip@@YA_NXZ)␍
          mysqlclient.lib(my_init.obj) : error LNK2019: unresolved external symbol __imp_RegEnumValueA referenced in function "void __cdecl win_init_registry(void)" (?win_init_registry@@YAXXZ)␍
          mysqlclient.lib(my_init.obj) : error LNK2019: unresolved external symbol __imp_RegOpenKeyExA referenced in function "bool __cdecl win32_have_tcpip(void)" (?win32_have_tcpip@@YA_NXZ)␍
          mysqlclient.lib(common.obj) : error LNK2019: unresolved external symbol __imp_EqualSid referenced in function "public: bool __cdecl Sid::operator==(class Sid const &)" (??8Sid@@QEAA_NAEBV0@@Z)␍
          mysqlclient.lib(common.obj) : error LNK2019: unresolved external symbol __imp_GetTokenInformation referenced in function "public: __cdecl Sid::Sid(void *)" (??0Sid@@QEAA@PEAX@Z)␍
          mysqlclient.lib(common.obj) : error LNK2019: unresolved external symbol __imp_IsValidSid referenced in function "public: bool __cdecl Sid::is_valid(void)const " (?is_valid@Sid@@QEBA_NXZ)␍
          mysqlclient.lib(common.obj) : error LNK2019: unresolved external symbol __imp_LookupAccountNameW referenced in function "public: __cdecl Sid::Sid(wchar_t const *)" (??0Sid@@QEAA@PEB_W@Z)␍
          D:\a\diesel\diesel\target\debug\deps\tests-1cc142ef763bf67a.exe : fatal error LNK1120: 7 unresolved externals␍

Link to the relevant CI run

Version it worked on

It most recently worked on: Current stable (1.86.0)

Version with regression

rustc --version --verbose:

rustc 1.87.0-beta.1 (45165c82a 2025-04-01)

@rustbot label: O-windows regression-from-stable-to-beta

[jieyouxu]

Judging from symbol names, probably #138233 (relnotes #138621) but someone more familiar with Windows might want to double-check.

[apiraino]

Yes, @weiznich noted that in comment and patched a fix in sgrif/mysqlclient-sys@2b3ff91

(cross-linking FIY, assuming this issue is about that)

[weiznich]

Just as a heads up: The linked fix does not completely fix the problem due to mistakes on my side. Additionally it only fixes users that actively update to a newer version. Any older mysqlclient-sys version is still affected by this build breaking change.

[apiraino]

I think cc: @smmalis37 @ChrisDenton for #138233

[ChrisDenton]

We could delay the change to give people more time to update but in general crates cannot depend on implementation details of the standard library if they want stability (as most do).