Skip to content

Cannot run any run-make test without checking out the cargo submodule #135573

Closed as duplicate of#134109
@RalfJung

Description

@RalfJung

I generally want to have as few git submodule checked out as possible in the rustc repo, since all the checked out submodules need to be synced each time they change and I'd like to minimize the number of time I have to run git submodule update --recursive. Therefore, I do not have the cargo submodule checked out.

However, this means I cannot run ./x test run-make. My understanding is that some run-make tests need cargo, but most do not, so it is unfortunate that I cannot run the non-cargo-using run-make tests without checking out cargo. Would be nice to check this in the test rather than blanket rejecting the entire test suite when cargo is missing.

(Also maybe one could use bootstrap cargo instead of the submodule? But I assume there's a reason the submodule is used so this probably does not work.)

Cc @jieyouxu

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-run-makeArea: port run-make Makefiles to rmake.rsC-discussionCategory: Discussion or questions that doesn't represent real issues.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions