fns using c-stack-cdecl native ABI cannot be called from outside crate

[nikomatsakis]

Calling a native function declared with "c-stack-cdecl" ABI from outside the create fails in LLVM. The type of the function includes the implicit parameters when it should not. The path through the code is: The code path is that when we look up the external identifier we go through trans_external_path() -> type_of_ty_param_kinds_and_ty() -> type_of_fn_from_ty() -> type_of_fn(), and type_of_fn() adds the implicit parameters.

I added a test: src/test/run-pass/invoke-external-native.rs

[brson]

I don't see how this works for "cdecl" functions.

[brson]

Maybe cdecl functions have a wrapper...

[nikomatsakis]

First question: do cdecl functions work? I would be happy to investigate this further, should be easy to port the test over to cdecl.

[brson]

Yeah, native "cdecl" functions do work across crates. Some of the stdtest::run tests rely on this. I'm thinking of just working around the problem in order to eliminate the last usages of "cdecl".

[nikomatsakis]

Oh, ok. Yeah, that's annoying. I didn't trace the path through the code that cdecl functions take, clearly something different though.

On Nov 7, 2011, at 7:45 PM, Brian Anderson wrote:

Yeah, native "cdecl" functions do work across crates. Some of the stdtest::run tests rely on this. I'm thinking of just working around the problem in order to eliminate the last usages of "cdecl".

---

Reply to this email directly or view it on GitHub:
https://github.com/graydon/rust/issues/1059#issuecomment-2663511

[nikomatsakis]

After some review, I think the way that it worked was that "cdecl" natives got wrapped in a rust wrapper. I plan to re-implement this at some point, it seems that it solves a myriad of issues (#1058, #1174, at least).

[nikomatsakis]

Fixed in @b6af844