Skip to content
This repository was archived by the owner on Oct 9, 2018. It is now read-only.

expand comments section #2

Merged
merged 1 commit into from
Jun 30, 2014
Merged

Conversation

nathantypanski
Copy link
Contributor

I did some work on expanding the comments guidelines.

Any feedback is appreciated.

documentation that you would like to be included in Rustdoc's output.
They support
[Markdown syntax](http://daringfireball.net/projects/markdown/)
and are the main way of documenting your code.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"the main way of documenting your public APIs" would be a bit more precise.

@aturon
Copy link
Member

aturon commented Jun 30, 2014

This is great, thanks so much for contributing! I've made a couple of minor comments -- if you could update the PR accordingly, I'd be happy to merge it.

@nathantypanski
Copy link
Contributor Author

Updated. Let me know if you have more to add.

These blocks should be simple enough to demonstrate the feature and
give some context on how to use it.

Imports should generally be module-qualified, for example:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is redundant with the section on imports (style/imports.html) -- is there something beyond those general guidelines that particularly applies to code snippets in doc comments?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, I'll just nix it for now and leave it as "open" for now - since we might have something decent to say about it, but I haven't thought of it.

@nathantypanski
Copy link
Contributor Author

Changed - I removed the bits about code snippets, just leaving it as "open" for now.

Edit: Or, does this change the whole section to "open" if there's an unanswered section? We could either:

  • remove the Code snippets section,
  • [OPEN] the whole markdown file,
  • leave it as is ([RFC] at the file level, [OPEN] at the subsection level) and hope someone has a good idea to contribute soon.

@aturon
Copy link
Member

aturon commented Jun 30, 2014

I think it's fine to leave [RFC] at the top, [OPEN] within for now; we'll get more formal about the status stuff later on. Thanks again!

aturon added a commit that referenced this pull request Jun 30, 2014
@aturon aturon merged commit 8df09d4 into rust-lang:master Jun 30, 2014
@nathantypanski nathantypanski deleted the style-comments branch June 30, 2014 22:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants