Verify character class still non-empty after converting to byte class #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wasn't sure if you'd prefer moving the original I didn't look into the |
For `[^\x00-\xff]`, while it is still treated as a full Unicode character class, it is not empty. For instance `≥` would still be matched. However, when `CharClass::to_byte_class` is called on it (as is done when using `regex::bytes::Regex::new` rather than `regex::Regex::new`), it _is_ now empty, since it excludes all possible bytes. This commit adds a test asserting that `regex::bytes::Regex::new` returns `Err` for this case (in accordance with rust-lang#106) and adds an `is_empty` check to the result of calling `CharClass::to_byte_class`, which allows the test to pass.
scooter-dangle
force-pushed
the
panic-on-empty-byte-range-for-bytes-regex
branch
from
2d1a77d to
b96e5cb
Compare
|
I finally had a chance to actually dig into the problem you described and I agree with your analysis and the fix. Thank you so much! I will add a test to |
|
Thanks for looking into it and merging! (Also, thanks for being patient while I was verifying where/how we were seeing the issue.) |
BurntSushi
added a commit
that referenced
this pull request
Dec 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
[^\x00-\xff], while it is still treated as a full Unicode character class, it is not empty. For instance≥would still be matched.However, when
CharClass::to_byte_classis called on it (as is done when usingregex::bytes::Regex::newrather thanregex::Regex::new), it is now empty, since it excludes all possible bytes.This commit adds a test asserting that
regex::bytes::Regex::newreturnsErrfor this case (in accordance with #106) and adds anis_emptycheck to the result of callingCharClass::to_byte_class, which allows the test to pass.Fixes #303