Skip to content

fancy graph UwU #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/deploy_mdbook.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,12 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Install mdbook-skill-tree
run: cargo install --git https://github.com/nikomatsakis/skill-tree.git mdbook-skill-tree
continue-on-error: true # we don't care if this is already cached

- name: Install skill tree files
run: mdbook-skill-tree install
- uses: XAMPPRocky/deploy-mdbook@v1
with:
token: ${{ secrets.GITHUB_TOKEN }}
1 change: 1 addition & 0 deletions SUMMARY.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
- [📜 Charter](./CHARTER.md)
- [🔮 The vision](./vision.md)
- [🙋‍♀️ Cast of characters](./vision/characters.md)
- [🔀 Skill Tree](./skill-tree.md)
- [😱 Status quo](./vision/status_quo.md)
- [Array defaults](./vision/status_quo/array_default.md)
- [Array split first method](./vision/status_quo/split_first.md)
Expand Down
9 changes: 7 additions & 2 deletions book.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ multilingual = false
src = "."
title = "Const Generics Project Group"

[preprocessor.skill-tree]
command = "mdbook-skill-tree"

[output.html]
no-section-label=true
git-repository-url="https://github.com/rust-lang/project-const-generics"
no-section-label = true
git-repository-url = "https://github.com/rust-lang/project-const-generics"
additional-js = ["viz.js", "panzoom.min.js", "full.render.js", "skill-tree.js"]
additional-css = ["skill-tree.css", "skill-tree-finetuning.css"]
3 changes: 3 additions & 0 deletions skill-tree-finetuning.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
:root {
--content-max-width: 2000px;
}
91 changes: 91 additions & 0 deletions skill-tree.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,91 @@
# Skill tree for const generics features

```skill-tree
[[group]]
name = "min_cg"
label = "MIN CONST GENERICS"
description = ["Minimum subset of const generics only allowing `const N: {integer} | bool | char` and fully concrete constants"]
href = "https://github.com/rust-lang/rust/pull/79135"
items = []

[[group]]
name = "valtree"
label = "VALTREES"
description = ["Use valtrees in all type level constants"]
items = [
{ label = "Design of structural equality is worked out" },
{ label = "Valtrees are implemented" },
]

[[group]]
name = "min_defaults"
label = "CONCRETE CONST DEFAULTS"
description = ["Permit concrete defaults on traits/adts"]
items = []
requires = ["min_cg"]

[[group]]
name = "generic_defaults"
label = "GENERIC CONST DEFAULTS"
description = ["Permit generic defaults on traits/adts"]
items = [
{ label = "Disallow usage of forward declared params via param env" },
{ label = "Decide when a generic default is considered well formed" },
]
requires = ["min_defaults"]

[[group]]
name = "param_tys"
label = "MORE CONST PARAM TYPES"
description = ["Permit more types to be as the type of a const generic"]
items = [
{ label = "A `Constable` that that signifies a type is valid to use as a const param type" },
{ label = "Generic const param types i.e. `T: Constable, const N: T`" },
{ label = "Consider `impl<const N: usize> Trait<{ Some(N) }> for ()` to constrain `N`" },
]
requires = ["valtree", "min_cg"]

[[group]]
name = "exhaustiveness"
label = "IMPL EXHAUSTIVENESS"
description = ["Allow separate impls to be used to fulfill `for<const N: usize> (): Trait<N>`"]
items = []
requires = ["param_tys"]

[[group]]
name = "min_generic_consts"
label = "MIN GENERIC CONSTANTS"
description = ["Allow type level constants to be generic i.e. `N + 1`"]
items = [
{ label = "Add a where clause that requires a given expression to be evaluatable e.g. `where evaluatable { N - 1 }`" },
{ label = "Unused substs make it hard to tell if a const is concrete or generic and breaks unsize coercion in some cases" },
{ label = "Don't eagerly error when evaluating constants during selection" },
]
requires = ["min_cg"]

[[group]]
name = "generic_consts"
label = "GENERIC CONSTANTS"
description = ["Allow type level constants but better ✨"]
items = [
{ label = "Allow writing a where clause that requires a condition to hold e.g. `where { N > 2 }`" },
{ label = "Some things can always evaluate and should not need a where clause e.g. `{ N == M }` `{ N / 1 }`" },
{ label = "If possible `where { N > 0 }` should imply `N - 1` is evaluatable" },
]
requires = ["min_generic_consts"]

[[group]]
name = "assoc_const_bounds"
label = "ASSOCIATED CONST BOUNDS"
description = ["Permit where `where T: Trait<ASSOC = 10>`"]
items = []
requires = ["min_generic_consts"]

[[group]]
name = "arg_infer"
label = "GENERIC ARG CONST INFER"
description = ["Permit using `_` for generic args"]
href = "https://github.com/rust-lang/rust/pull/83484"
items = []
requires = ["min_cg"]
```