This repository was archived by the owner on Sep 30, 2020. It is now read-only.
Clean up smaller sized icons and add higher res icon to favicon.ico
#106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a 48x48 and 196x196 icon to `favicon.ico`. 196x196 is the recommended size for google chrome on mobile for large shortcut icons. Additionally, clean up the visibility of the rust icon at small sizes.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
|
r? @brson Not sure if these came from a particular source or not and if we need to consider that. |
brson
added a commit
that referenced
this pull request
Apr 17, 2015
Clean up smaller sized icons and add higher res icon to `favicon.ico`
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a 48x48 and 196x196 icon to
favicon.ico. 196x196 is therecommended size for google chrome on mobile for large shortcut icons.
Additionally, clean up the visibility of the rust icon at small sizes.