Skip to content

Make Error implement Send. #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 29, 2014

Conversation

akosthekiss
Copy link
Contributor

Fixes #33

@akosthekiss
Copy link
Contributor Author

Note: Travis is reporting the following error:

error: implementing the trait `core::kinds::Send` is not unsafe`

However, my more recent rustc complains if I remove unsafe:

error: the trait `core::kinds::Send` requires an `unsafe impl` declaration

@alexcrichton
Copy link
Member

Thanks! I'll wait for this change to hit nightlies to merge.

Could you also move this to the Error type instead? I would expect it to be more appropriately placed there instead of the FFI bindings.

@akosthekiss
Copy link
Contributor Author

You are right, it's cleaner this way. Thanks.

@akosthekiss akosthekiss changed the title Make git_error implement Send. Make Error implement Send. Dec 28, 2014
alexcrichton added a commit that referenced this pull request Dec 29, 2014
@alexcrichton alexcrichton merged commit e335ec2 into rust-lang:master Dec 29, 2014
@akosthekiss akosthekiss deleted the pr-git_error-send branch January 3, 2015 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libgit2-sys::git_error must implement core::kinds::Send
2 participants