-
Notifications
You must be signed in to change notification settings - Fork 210
Update Font Awesome & Tera and refactor templates #957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can we make the icons in the file list fixed width? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also squash away all the previous commits? We don't need to have fontawesome vendored forever inside the repository even though we don't use it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we separate the upgrade from the refactor? I think I heard the refactor depends on the upgrade, so we could do the upgrade first without any large changes to docs.rs itself.
The upgrade is just bumping versions, does that matter? |
Yes, not all projects correctly follow semver (or make accidental breaking changes) and even if there's no breaking change there could be a large performance difference, since most projects don't track that. For example this happened with tokio 0.2 and html5ever 0.24. |
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.6.3/css/font-awesome.min.css" | ||
type="text/css" media="all" /> | ||
======= | ||
<link rel="stylesheet" href="https://use.fontawesome.com/releases/v5.14.0/css/all.css" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does this URL come from? I don't see anywhere on the main website listing it as a CDN?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This page in the codeblock of the Upgrading Manually
section
We discussed this on discord and decided that since there have been very few changes since 1.3.1 it's ok to do both at once. |
Before:
After:
r? @pietroalbini