Skip to content

Update Font Awesome & Tera and refactor templates #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 13, 2020

Conversation

Kixiron
Copy link
Member

@Kixiron Kixiron commented Aug 11, 2020

  • Update to Font Awesome 5
  • Update to Tera 1.5
  • Use custom filters for making icons
  • Made some of the icons fancier

Before:

image
image

After:

image
image

r? @pietroalbini

@Nemo157
Copy link
Member

Nemo157 commented Aug 12, 2020

Can we make the icons in the file list fixed width?

Copy link
Member

@pietroalbini pietroalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also squash away all the previous commits? We don't need to have fontawesome vendored forever inside the repository even though we don't use it.

@Kixiron Kixiron requested a review from pietroalbini August 12, 2020 15:56
@jyn514 jyn514 added A-frontend Area: Web frontend C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Aug 13, 2020
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we separate the upgrade from the refactor? I think I heard the refactor depends on the upgrade, so we could do the upgrade first without any large changes to docs.rs itself.

@Kixiron
Copy link
Member Author

Kixiron commented Aug 13, 2020

The upgrade is just bumping versions, does that matter?

@jyn514
Copy link
Member

jyn514 commented Aug 13, 2020

Yes, not all projects correctly follow semver (or make accidental breaking changes) and even if there's no breaking change there could be a large performance difference, since most projects don't track that. For example this happened with tokio 0.2 and html5ever 0.24.

<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.6.3/css/font-awesome.min.css"
type="text/css" media="all" />
=======
<link rel="stylesheet" href="https://use.fontawesome.com/releases/v5.14.0/css/all.css" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this URL come from? I don't see anywhere on the main website listing it as a CDN?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page in the codeblock of the Upgrading Manually section

@jyn514
Copy link
Member

jyn514 commented Aug 13, 2020

Can we separate the upgrade from the refactor? I think I heard the refactor depends on the upgrade, so we could do the upgrade first without any large changes to docs.rs itself.

We discussed this on discord and decided that since there have been very few changes since 1.3.1 it's ok to do both at once.

@jyn514 jyn514 merged commit 1107e9b into rust-lang:master Aug 13, 2020
@Kixiron Kixiron deleted the features branch August 13, 2020 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend Area: Web frontend C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants