Skip to content

Fixed details dropdown #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 15, 2020
Merged

Fixed details dropdown #890

merged 5 commits into from
Jul 15, 2020

Conversation

Kixiron
Copy link
Member

@Kixiron Kixiron commented Jul 15, 2020

In the Versions lists any crate release that was not a library was incorrectly said to have failed to build when it should say that the crate isn't a library

Previous behavior:

image

Fixed behavior:

image

I was also getting rustfmt errors from the badges crate, so I ran a quick fmt on that in the second commit

@Kixiron Kixiron added C-bug Category: This is a bug A-frontend Area: Web frontend S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Jul 15, 2020
@Kixiron Kixiron requested a review from jyn514 July 15, 2020 17:17
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a test for the new feature? See https://github.com/rust-lang/docs.rs/blob/master/src/web/releases.rs#L1055 for an example using kuchiki.

@jyn514
Copy link
Member

jyn514 commented Jul 15, 2020

The test failure is

2020-07-15T17:23:20.0381605Z failures:
2020-07-15T17:23:20.0381886Z 
2020-07-15T17:23:20.0383149Z ---- web::crate_details::tests::test_releases_should_be_sorted stdout ----
2020-07-15T17:23:20.0633434Z thread 'main' panicked at 'assertion failed: `(left == right)`
2020-07-15T17:23:20.0634469Z   left: `[Release { version: "1.0.0", build_status: true, yanked: false, is_library: true }, Release { version: "0.12.0", build_status: true, yanked: false, is_library: true }, Release { version: "0.3.0", build_status: false, yanked: false, is_library: true }, Release { version: "0.2.0", build_status: false, yanked: false, is_library: false }, Release { version: "0.2.0-alpha", build_status: true, yanked: false, is_library: true }, Release { version: "0.1.1", build_status: true, yanked: false, is_library: true }, Release { version: "0.1.0", build_status: true, yanked: false, is_library: true }]`,
2020-07-15T17:23:20.0635707Z  right: `[Release { version: "1.0.0", build_status: true, yanked: false, is_library: true }, Release { version: "0.12.0", build_status: true, yanked: false, is_library: true }, Release { version: "0.3.0", build_status: false, yanked: false, is_library: true }, Release { version: "0.2.0", build_status: true, yanked: true, is_library: true }, Release { version: "0.2.0-alpha", build_status: true, yanked: false, is_library: true }, Release { version: "0.1.1", build_status: true, yanked: false, is_library: true }, Release { version: "0.1.0", build_status: true, yanked: false, is_library: true }, Release { version: "0.2.0", build_status: false, yanked: false, is_library: false }]`', src/web/crate_details.rs:459:13

@Kixiron
Copy link
Member Author

Kixiron commented Jul 15, 2020

I fixed the failure but github's being weird with my fixup

@Kixiron Kixiron force-pushed the details-dropdown branch from 703e139 to 2b1d77c Compare July 15, 2020 17:47
@jyn514 jyn514 merged commit f311ee2 into rust-lang:master Jul 15, 2020
@Kixiron Kixiron deleted the details-dropdown branch July 15, 2020 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend Area: Web frontend C-bug Category: This is a bug S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants