Skip to content

Add canonical URL for releases page #1870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jsha
Copy link
Contributor

@jsha jsha commented Oct 5, 2022

No description provided.

@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Oct 5, 2022
@@ -3,6 +3,10 @@

{%- block title -%}{{ title | default(value="Releases - Docs.rs")}}{%- endblock title -%}

{%- block meta -%}
<link rel="canonical" href="https://docs.rs/releases/{{ owner }}" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This template is used on all release-pages, so will fail for the latest-releases or search-result page etc.

I assume you wanted to canonicalize /@owner and /owner pages?

@syphar syphar added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Oct 5, 2022
@jsha
Copy link
Contributor Author

jsha commented Oct 13, 2022

Closing in favor of #1879

@jsha jsha closed this Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This PR is incomplete or needs to address review comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants