Skip to content

Fix position of navbar sub menu items #1812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2022
Merged

Fix position of navbar sub menu items #1812

merged 1 commit into from
Aug 31, 2022

Conversation

GuillaumeGomez
Copy link
Member

Fixes #1810.

@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Aug 31, 2022
Nemo157
Nemo157 approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@Nemo157 Nemo157 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine on https://docs.rs.dev.nemo157.com

@GuillaumeGomez
Copy link
Member Author

Thanks for uploading it and testing it!

@GuillaumeGomez
Copy link
Member Author

Merging then!

@GuillaumeGomez GuillaumeGomez merged commit f8ccd48 into rust-lang:master Aug 31, 2022
@GuillaumeGomez GuillaumeGomez deleted the fix-navbar-sub-items-pos branch August 31, 2022 18:07
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Aug 31, 2022
@syphar
Copy link
Member

syphar commented Sep 1, 2022

@GuillaumeGomez from what I remember, @jyn514 ( and also me) prefer linear history, so we typically do rebase-merges.

@GuillaumeGomez
Copy link
Member Author

Oh sorry. Noted for next time. Also: can it be forced in the project settings by any chance?

@syphar
Copy link
Member

syphar commented Sep 1, 2022

Oh sorry. Noted for next time. Also: can it be forced in the project settings by any chance?

yeah, this can be configured

@GuillaumeGomez
Copy link
Member Author

Cool! Just need someone to do it now. 😆

@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nemo157 Nemo157 Nemo157 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Menus are detached if scrolled down
3 participants
@GuillaumeGomez @syphar @Nemo157