CI: use rust-cache action for faster CI #1319
Merged
+4
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-cache caches most of the directories we cached previously, while additionally deleting files that we don't need in the cache. Since the action already removes old files from the cache, we don't need cargo-sweep any more.
|
This looks good to me. @Kixiron do you have opinions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-cache caches most of the directories we cached previously, while
additionally deleting files that we don't need in the cache (about the files being cached, see here and here)
Since the action already removes old files from the cache, we don't need
cargo-sweep any more. Slight difference is (to my understanding) that sweep is based on timestamping before and after the build, and this action just deletes files with mtime > 7 days.
improvements:
If I'm wrong with the assumption that we can remove cargo-sweep I'm happy to add it back, with the difference of the cache being used.