Skip to content

crates_io_tarball: Use insta snapshots to simplify test code #8786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Jun 4, 2024

This makes it easier to write the error assertions, and has the added benefit of testing the derived Display trait of the error enum.

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Jun 4, 2024
@Turbo87 Turbo87 enabled auto-merge (squash) June 4, 2024 11:17
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.68%. Comparing base (46a28ee) to head (c377253).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8786      +/-   ##
==========================================
+ Coverage   88.67%   88.68%   +0.01%     
==========================================
  Files         276      276              
  Lines       27645    27647       +2     
==========================================
+ Hits        24513    24518       +5     
+ Misses       3132     3129       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Turbo87 Turbo87 merged commit ba7b73a into rust-lang:main Jun 4, 2024
9 checks passed
@Turbo87 Turbo87 deleted the insta-tarball branch June 4, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant