Skip to content

Remove deprecated /api/v1/versions endpoints #7943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Jan 15, 2024

These endpoints were deprecated by 1364c27 in 2017 (6ish years ago).

Over the past months we only had a single bot using this API and they were requesting /api/v1/versions without any query parameters and always getting back an empty array... 🤷‍♂️

@Turbo87 Turbo87 requested a review from a team January 15, 2024 11:03
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍, let's say good-bye.

@Turbo87 Turbo87 force-pushed the remove-versions-endpoints branch from 57f509a to d2d3899 Compare January 16, 2024 11:26
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8b81b7e) 87.52% compared to head (e9c3878) 87.45%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7943      +/-   ##
==========================================
- Coverage   87.52%   87.45%   -0.08%     
==========================================
  Files         257      254       -3     
  Lines       24998    24890     -108     
==========================================
- Hits        21880    21768     -112     
- Misses       3118     3122       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@LawnGnome LawnGnome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

giphy

@Turbo87 Turbo87 force-pushed the remove-versions-endpoints branch from d2d3899 to e9c3878 Compare January 17, 2024 13:01
@Turbo87 Turbo87 merged commit c9f2431 into rust-lang:main Jan 18, 2024
@Turbo87 Turbo87 deleted the remove-versions-endpoints branch January 18, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants